- ghc-devs - Haskell.org

Windows build failing in a new way
by Simon Peyton Jones 10 Mar '17

10 Mar '17

My windows build is more broken than usual. I can't even build a GHC. Please, could someone fix this? I'm getting desperate. Simon libtool: compile: C:/code/HEAD/inplace/mingw/bin/gcc.exe -DHAVE_CONFIG_H -I. -I.. -I. -I../include -Iinclude -I../src -Wall -Werror -fno-stack-protector -w -fexceptions -MT src/x86/ffi64.lo -MMD -MP -MF src/x86/.deps/ffi64.Tpo -c ../src/x86/ffi64.c -o src/x86/ffi64.o depbase=`echo src/x86/unix64.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\ /bin/sh ./libtool --mode=compile C:/code/HEAD/inplace/mingw/bin/gcc.exe -DHAVE_CONFIG_H -I. -I.. -I. -I../include -Iinclude -I../src -I. -I../include -Iinclude -I../src -Wall -Werror -fno-stack-protector -w -MT src/x86/unix64.lo -MMD -MP -MF $depbase.Tpo -c -o src/x86/unix64.lo ../src/x86/unix64.S &&\ mv -f $depbase.Tpo $depbase.Plo libtool: compile: C:/code/HEAD/inplace/mingw/bin/gcc.exe -DHAVE_CONFIG_H -I. -I.. -I. -I../include -Iinclude -I../src -I. -I../include -Iinclude -I../src -Wall -Werror -fno-stack-protector -w -MT src/x86/unix64.lo -MMD -MP -MF src/x86/.deps/unix64.Tpo -c ../src/x86/unix64.S -o src/x86/unix64.o ../src/x86/unix64.S: Assembler messages: ../src/x86/unix64.S:45: Error: junk at end of line, first unrecognized character is `f' ../src/x86/unix64.S:204: Error: junk at end of line, first unrecognized character is `f' ../src/x86/unix64.S:208: Error: junk at end of line, first unrecognized character is `f' ../src/x86/unix64.S:326: Error: junk at end of line, first unrecognized character is `f' ../src/x86/unix64.S:334: Error: junk at end of line, first unrecognized character is `,' make[5]: *** [Makefile:1335: src/x86/unix64.lo] Error 1 make[5]: Leaving directory '/c/code/HEAD/libffi/build/x86_64-pc-msys' make[4]: *** [Makefile:1596: all-recursive] Error 1 make[4]: Leaving directory '/c/code/HEAD/libffi/build/x86_64-pc-msys' make[3]: *** [Makefile:730: all] Error 2 make[3]: Leaving directory '/c/code/HEAD/libffi/build/x86_64-pc-msys' make[2]: *** [Makefile:608: all-all] Error 2 rts/ghc.mk:494: rts/dist/build/.depend-v-l-debug-thr-thr_debug-thr_l.c_asm: No such file or directory make[1]: *** [libffi/ghc.mk:115: libffi/stamp.ffi.static.build] Error 2 make: *** [Makefile:127: all] Error 2 /c/code/HEAD$

4 10

RE: [commit: ghc] master: Add a comment to the mapFB rules (665cefe)
by Simon Peyton Jones 09 Mar '17

09 Mar '17

| +-- The "mapFB" rule optimises compositions of map and | +-- the "mapFB/id" rule get rids of 'map id' calls. | +-- (Any similarity to the Functor laws for [] is expected.) Yes, obviously. But did you have a use-case, or did you just to this on principle? If you don't have this rule what goes wrong. You must have had a proximate reason for adding it. Oh. And I've just realised that mapFB c id will turn into \x y. c x y as soon as you inline mapFB. So why do you need a RULE to do that? Why not leave it for the inliner? Simon | -----Original Message----- | From: ghc-commits [mailto:ghc-commits-bounces@haskell.org] On Behalf | Of git(a)git.haskell.org | Sent: 09 March 2017 15:14 | To: ghc-commits(a)haskell.org | Subject: [commit: ghc] master: Add a comment to the mapFB rules | (665cefe) | | Repository : ssh://git@git.haskell.org/ghc | | On branch : master | Link : | https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fghc.ha | skell.org%2Ftrac%2Fghc%2Fchangeset%2F665cefe80d112ed2e4fb9617d277a1466 | e83f9bd%2Fghc&data=02%7C01%7Csimonpj%40microsoft.com%7C8854d69a18b4459 | e528808d466feef08%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C6362466 | 92510080066&sdata=IR%2BftPvaSs2xZa74FEWe67ynoP6bgLKOExK7jtPe4Yg%3D&res | erved=0 | | >--------------------------------------------------------------- | | commit 665cefe80d112ed2e4fb9617d277a1466e83f9bd | Author: Joachim Breitner <mail(a)joachim-breitner.de> | Date: Thu Mar 9 16:13:08 2017 +0100 | | Add a comment to the mapFB rules | | to amend 2fa44217c1d9722227297eefb0d6c6aed7e128ca. | | | >--------------------------------------------------------------- | | 665cefe80d112ed2e4fb9617d277a1466e83f9bd | libraries/base/GHC/Base.hs | 6 ++++-- | 1 file changed, 4 insertions(+), 2 deletions(-) | | diff --git a/libraries/base/GHC/Base.hs b/libraries/base/GHC/Base.hs | index 6f9d454..a678c22 100644 | --- a/libraries/base/GHC/Base.hs | +++ b/libraries/base/GHC/Base.hs | @@ -964,10 +964,12 @@ mapFB c f = \x ys -> c (f x) ys | -- (along with build's unfolding) else we'd get an infinite loop | -- in the rules. Hence the activation control below. | -- | --- The "mapFB" rule optimises compositions of map. | --- | -- This same pattern is followed by many other functions: | -- e.g. append, filter, iterate, repeat, etc. | +-- | +-- The "mapFB" rule optimises compositions of map and | +-- the "mapFB/id" rule get rids of 'map id' calls. | +-- (Any similarity to the Functor laws for [] is expected.) | | {-# RULES | "map" [~1] forall f xs. map f xs = build (\c n | -> foldr (mapFB c f) n xs) | | _______________________________________________ | ghc-commits mailing list | ghc-commits(a)haskell.org | https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmail.h | askell.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fghc- | commits&data=02%7C01%7Csimonpj%40microsoft.com%7C8854d69a18b4459e52880 | 8d466feef08%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C6362466925100 | 80066&sdata=cU6XkSWb5Lg1oaEnVPwB2%2BesI9jtneA2051MhD4SnnM%3D&reserved= | 0

2 1

Better perf
by Simon Peyton Jones 09 Mar '17

09 Mar '17

I've just committed this patch sequence fb9ae288088a3eabc4e1bb4e86fa473a3881d2e2 Make FloatOut/SetLevels idemoptent on bottoming functions 995ab74b3c55fe3a0299bd94b49e948c942e76d6 Comments only 1163f4f2fe9aabd722c963497c67c5f8c71ef71b Tiny refactor 9b2c73ea8082199245bfa6a28390b70b38f87fd1 Make TH_Roles2 less fragile 9304df5230a7a29d3e992916d133e462b854e55f Fix CSE (again) on literal strings In my final validate run (after updating to HEAD) I saw Unexpected stat failures: perf/compiler/T13035.run T13035 [stat too good] (normal) -6.4% alloc perf/compiler/T12425.run T12425 [stat too good] (optasm) -6.6% alloc perf/compiler/T9675.run T9675 [stat too good] (optasm) -10.4% alloc perf/compiler/T1969.run T1969 [stat too good] (normal) -21% peak megabytes perf/space_leaks/T4029.run T4029 [stat too good] (ghci) -14% peak megabytes This is good. I did not see these in earlier validations (perhaps I did not rebuild the libraries sufficiently), so I have left them. If Harbormaster agrees that perf has improved, could someone re-centre the numbers? Ideally say which patch is responsible. Simon

3 5

RE: [commit: ghc] master: Deserialize IfaceId more lazily (6446254)
by Simon Peyton Jones 08 Mar '17

08 Mar '17

Reid I beg you to add a comment to these carefully-placed used of laziness! The informative commit message does not appear in the code :-). Simon | -----Original Message----- | From: ghc-commits [mailto:ghc-commits-bounces@haskell.org] On Behalf | Of git(a)git.haskell.org | Sent: 03 March 2017 21:36 | To: ghc-commits(a)haskell.org | Subject: [commit: ghc] master: Deserialize IfaceId more lazily | (6446254) | | Repository : ssh://git@git.haskell.org/ghc | | On branch : master | Link : | https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fghc.ha | skell.org%2Ftrac%2Fghc%2Fchangeset%2F644625449a9b6fbeb9a81f1a7d0e7d184 | 24fb707%2Fghc&data=02%7C01%7Csimonpj%40microsoft.com%7C9b1a8ffea4684b8 | f5e7608d4627d690f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C6362417 | 38152433434&sdata=H81TTDPPgdp%2BYQzqRFUtiyyfm%2Fn6YRQT%2BoOpJuehsOU%3D | &reserved=0 | | >--------------------------------------------------------------- | | commit 644625449a9b6fbeb9a81f1a7d0e7d18424fb707 | Author: Reid Barton <rwbarton(a)gmail.com> | Date: Fri Mar 3 15:49:38 2017 -0500 | | Deserialize IfaceId more lazily | | This change sped up the total validate --build-only time by 0.8% | on my test system; hopefully a representative result. | | I didn't bother making the other constructors lazy because for | IfaceData and IfaceClass we need to pull on some of the fields | in loadDecl, and all the others seem much more rare than IfaceId. | | Test Plan: validate, perf | | Reviewers: austin, bgamari | | Reviewed By: bgamari | | Subscribers: thomie | | Differential Revision: https://phabricator.haskell.org/D3269 | | | >--------------------------------------------------------------- | | 644625449a9b6fbeb9a81f1a7d0e7d18424fb707 | compiler/iface/IfaceSyn.hs | 8 ++------ | 1 file changed, 2 insertions(+), 6 deletions(-) | | diff --git a/compiler/iface/IfaceSyn.hs b/compiler/iface/IfaceSyn.hs | index d73a738..1c30476 100644 | --- a/compiler/iface/IfaceSyn.hs | +++ b/compiler/iface/IfaceSyn.hs | @@ -1565,9 +1565,7 @@ instance Binary IfaceDecl where | put_ bh (IfaceId name ty details idinfo) = do | putByte bh 0 | putIfaceTopBndr bh name | - put_ bh ty | - put_ bh details | - put_ bh idinfo | + lazyPut bh (ty, details, idinfo) | | put_ bh (IfaceData a1 a2 a3 a4 a5 a6 a7 a8 a9) = do | putByte bh 2 | @@ -1657,9 +1655,7 @@ instance Binary IfaceDecl where | h <- getByte bh | case h of | 0 -> do name <- get bh | - ty <- get bh | - details <- get bh | - idinfo <- get bh | + ~(ty, details, idinfo) <- lazyGet bh | return (IfaceId name ty details idinfo) | 1 -> error "Binary.get(TyClDecl): ForeignType" | 2 -> do a1 <- getIfaceTopBndr bh | | _______________________________________________ | ghc-commits mailing list | ghc-commits(a)haskell.org | https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmail.h | askell.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fghc- | commits&data=02%7C01%7Csimonpj%40microsoft.com%7C9b1a8ffea4684b8f5e760 | 8d4627d690f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C6362417381524 | 33434&sdata=L1dvXY%2BW%2Brv4gMqeWm8BGfIPifKK0DBndoJVF%2FCfu0c%3D&reser | ved=0

2 1

RE: [commit: ghc] master: Add rule mapFB c (λx.x) = c (2fa4421)
by Simon Peyton Jones 08 Mar '17

08 Mar '17

Joachim Please, I beg you, add a comment to explain why this rule is useful. I'm sure you had a good reason for adding it, but it's not apparent from the code. Thanks Simon | -----Original Message----- | From: ghc-commits [mailto:ghc-commits-bounces@haskell.org] On Behalf | Of git(a)git.haskell.org | Sent: 06 March 2017 23:52 | To: ghc-commits(a)haskell.org | Subject: [commit: ghc] master: Add rule mapFB c (λx.x) = c (2fa4421) | | Repository : ssh://git@git.haskell.org/ghc | | On branch : master | Link : | https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fghc.ha | skell.org%2Ftrac%2Fghc%2Fchangeset%2F2fa44217c1d9722227297eefb0d6c6aed | 7e128ca%2Fghc&data=02%7C01%7Csimonpj%40microsoft.com%7Cc5db3687da004cd | 11d0f08d464ebc6ca%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C6362444 | 11212143808&sdata=KMHS17MUXQUkBOaMbFiRxXiRM8gIvlEMGz%2FDw7F7Njo%3D&res | erved=0 | | >--------------------------------------------------------------- | | commit 2fa44217c1d9722227297eefb0d6c6aed7e128ca | Author: Joachim Breitner <mail(a)joachim-breitner.de> | Date: Mon Mar 6 17:30:52 2017 -0500 | | Add rule mapFB c (λx.x) = c | | Test Plan: exended T2110 with a case for that. | | Reviewers: austin, hvr, dfeuer, bgamari | | Reviewed By: dfeuer | | Subscribers: dfeuer, thomie | | Differential Revision: https://phabricator.haskell.org/D3275 | | | >--------------------------------------------------------------- | | 2fa44217c1d9722227297eefb0d6c6aed7e128ca | libraries/base/GHC/Base.hs | 1 + | testsuite/tests/simplCore/should_run/T2110.hs | 3 +++ | testsuite/tests/simplCore/should_run/T2110.stdout | 1 + | 3 files changed, 5 insertions(+) | | diff --git a/libraries/base/GHC/Base.hs b/libraries/base/GHC/Base.hs | index 2f155c6..6f9d454 100644 | --- a/libraries/base/GHC/Base.hs | +++ b/libraries/base/GHC/Base.hs | @@ -973,6 +973,7 @@ mapFB c f = \x ys -> c (f x) ys | "map" [~1] forall f xs. map f xs = build (\c n | -> foldr (mapFB c f) n xs) | "mapList" [1] forall f. foldr (mapFB (:) f) [] = map f | "mapFB" forall c f g. mapFB (mapFB c f) g = mapFB c | (f.g) | +"mapFB/id" forall c. mapFB c (\x -> x) = c | #-} | | -- See Breitner, Eisenberg, Peyton Jones, and Weirich, "Safe Zero- | cost diff --git a/testsuite/tests/simplCore/should_run/T2110.hs | b/testsuite/tests/simplCore/should_run/T2110.hs | index 610be09..d945fac 100644 | --- a/testsuite/tests/simplCore/should_run/T2110.hs | +++ b/testsuite/tests/simplCore/should_run/T2110.hs | @@ -5,6 +5,8 @@ import Unsafe.Coerce | | newtype Age = Age Int | | +foo :: [Int] -> [Int] | +foo = map id | fooAge :: [Int] -> [Age] | fooAge = map Age | fooCoerce :: [Int] -> [Age] | @@ -19,6 +21,7 @@ same x y = case reallyUnsafePtrEquality# | (unsafeCoerce x) y of | | main = do | let l = [1,2,3] | + same (foo l) l | same (fooAge l) l | same (fooCoerce l) l | same (fooUnsafeCoerce l) l | diff --git a/testsuite/tests/simplCore/should_run/T2110.stdout | b/testsuite/tests/simplCore/should_run/T2110.stdout | index 55f7ebb..4ff957b 100644 | --- a/testsuite/tests/simplCore/should_run/T2110.stdout | +++ b/testsuite/tests/simplCore/should_run/T2110.stdout | @@ -1,3 +1,4 @@ | yes | yes | yes | +yes | | _______________________________________________ | ghc-commits mailing list | ghc-commits(a)haskell.org | https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmail.h | askell.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fghc- | commits&data=02%7C01%7Csimonpj%40microsoft.com%7Cc5db3687da004cd11d0f0 | 8d464ebc6ca%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C6362444112121 | 43808&sdata=y%2BRYDSeV9k2Uj%2BlPtE%2BeIeG05mQvE97QV0B0wgl7cx4%3D&reser | ved=0

2 1

Better conditionals
by Simon Peyton Jones 08 Mar '17

08 Mar '17

Reid As promised: could you look at Trac #13397, re tagToEnum#. In particular, why is n-body running slower?? The change is basically a good one: removes a nasty special case in the code generator and de-clutters the code generally. So I'm keen to keep it. Not important for 8.2 though. Thanks Simon

1 0

Getting exceptions right
by David Feuer 07 Mar '17

07 Mar '17

I've put together a wiki page describing the issues I think we need to address, and laying out the model I think we want to implement for precise exceptions. Hopefully, this will help us figure out what we need to do to get a better story here. https://ghc.haskell.org/trac/ghc/wiki/FixingExceptions Thanks, David Feuer

2 1

Windows build broken again
by Simon Peyton Jones 07 Mar '17

07 Mar '17

The Windows build is broken again. Here's the tail of the log It would be good if we could stop this happening Simon == End post-build package check make: Entering directory '/c/code/HEAD/testsuite/tests' WARNING: cache is out of date: C:\code\HEAD\inplace\lib\package.conf.d\package.cache ghc will see an old view of this package db. Use 'ghc-pkg recache' to fix. WARNING: cache is out of date: C:\code\HEAD\inplace\lib\package.conf.d\package.cache ghc will see an old view of this package db. Use 'ghc-pkg recache' to fix. "/c/code/HEAD/inplace/bin/ghc-stage2.exe" --make -o ../mk/ghc-config ../mk/ghc-config.hs [1 of 1] Compiling Main ( ..\mk\ghc-config.hs, ..\mk\ghc-config.o ) Linking ../mk/ghc-config.exe ... ../mk/ghc-config "/c/code/HEAD/inplace/bin/ghc-stage2.exe" >"../mk/ghcconfig_c_code_HEAD_inplace_bin_ghc-stage2.exe.mk"; if [ $? != 0 ]; then rm -f "../mk/ghcconfig_c_code_HEAD_inplace_bin_ghc-stage2.exe.mk"; exit 1; fi WARNING: cache is out of date: C:\code\HEAD\inplace\lib\package.conf.d\package.cache ghc will see an old view of this package db. Use 'ghc-pkg recache' to fix. WARNING: cache is out of date: C:\code\HEAD\inplace\lib\package.conf.d\package.cache ghc will see an old view of this package db. Use 'ghc-pkg recache' to fix. # See Note [validate and testsuite speed] in toplevel Makefile. make SPEED=2 make[1]: Entering directory '/c/code/HEAD/testsuite/tests' WARNING: cache is out of date: C:\code\HEAD\inplace\lib\package.conf.d\package.cache ghc will see an old view of this package db. Use 'ghc-pkg recache' to fix. WARNING: cache is out of date: C:\code\HEAD\inplace\lib\package.conf.d\package.cache ghc will see an old view of this package db. Use 'ghc-pkg recache' to fix. Looks like you don't have timeout, building it first... make -C ../timeout all make[2]: Entering directory '/c/code/HEAD/testsuite/timeout' rm -f -f TimeMe.o TimeMe.hi TimeMe TimeMe.exe python3 calibrate '' > calibrate.out rm -rf install-inplace '/c/code/HEAD/inplace/bin/ghc-stage2.exe' --make Setup [1 of 1] Compiling Main ( Setup.hs, Setup.o ) Linking Setup.exe ... ./Setup configure --with-compiler='/c/code/HEAD/inplace/bin/ghc-stage2.exe' \ --with-hc-pkg='/c/code/HEAD/inplace/bin/ghc-pkg.exe' \ --with-hsc2hs='/c/code/HEAD/inplace/bin/hsc2hs.exe' \ \ --ghc-option=-threaded --prefix='/c/code/HEAD/testsuite/timeout/install-inplace' Configuring timeout-1... ./Setup build Preprocessing executable 'timeout' for timeout-1.. Building executable 'timeout' for timeout-1.. [1 of 2] Compiling WinCBindings ( dist\build\timeout\timeout-tmp\WinCBindings.hs, dist\build\timeout\timeout-tmp\WinCBindings.o ) [2 of 2] Compiling Main ( timeout.hs, dist\build\timeout\timeout-tmp\Main.o ) Linking dist\build\timeout\timeout.exe ... ./Setup install Installing executable timeout in C:/code/HEAD/testsuite/timeout/install-inplace\bin Warning: The directory C:/code/HEAD/testsuite/timeout/install-inplace\bin is not in the system search path. make[2]: Leaving directory '/c/code/HEAD/testsuite/timeout' PYTHON="python3" "python3" ../driver/runtests.py -e ghc_compiler_always_flags="'-dcore-lint -dcmm-lint -no-user-package-db -rtsopts -fno-warn-missed-specialisations -fshow-warning-groups -fdiagnostics-color=never -fno-diagnostics-show-caret -dno-debug-output'" -e config.compiler_debugged=False -e ghc_with_native_codegen=1 -e config.have_vanilla=True -e config.have_dynamic=False -e config.have_profiling=False -e ghc_with_threaded_rts=1 -e ghc_with_dynamic_rts=0 -e config.have_interp=True -e config.unregisterised=False -e config.ghc_dynamic_by_default=False -e config.ghc_dynamic=False -e ghc_with_smp=1 -e ghc_with_llvm=0 -e windows=True -e darwin=False -e config.in_tree_compiler=True --threads=5 -e config.cleanup=True -e config.local=False --rootdir=. --configfile=../config/ghc -e 'config.confdir="../config"' -e 'config.platform="x86_64-unknown-mingw32"' -e 'config.os="mingw32"' -e 'config.arch="x86_64"' -e 'config.wordsize="64"' -e 'config.timeout=int() or config.timeout' -e 'config.exeext=".exe"' -e 'config.top="/c/code/HEAD/testsuite"' --config 'compiler="/c/code/HEAD/inplace/bin/ghc-stage2.exe"' --config 'ghc_pkg="/c/code/HEAD/inplace/bin/ghc-pkg.exe"' --config 'haddock="/c/code/HEAD/inplace/bin/haddock.exe"' --config 'hp2ps="/c/code/HEAD/inplace/bin/hp2ps.exe"' --config 'hpc="/c/code/HEAD/inplace/bin/hpc.exe"' --config 'gs="gs"' --config 'timeout_prog="../timeout/install-inplace/bin/timeout.exe"' -e "config.stage=2" --summary-file "../../testsuite_summary.txt" --no-print-summary 1 --rootdir=../../libraries/Win32/tests --rootdir=../../libraries/array/tests --rootdir=../../libraries/base/tests --rootdir=../../libraries/binary/tests --rootdir=../../libraries/bytestring/tests --rootdir=../../libraries/containers/tests --rootdir=../../libraries/deepseq/tests --rootdir=../../libraries/directory/tests --rootdir=../../libraries/filepath/tests --rootdir=../../libraries/ghc-compact/tests --rootdir=../../libraries/ghc-prim/tests --rootdir=../../libraries/haskeline/tests --rootdir=../../libraries/hpc/tests --rootdir=../../libraries/pretty/tests --rootdir=../../libraries/process/tests --rootdir=../../libraries/template-haskell/tests \ \ \ \ \ \ -e config.speed="2" \ Traceback (most recent call last): File "../driver/runtests.py", line 189, in <module> pkginfo = str(getStdout([config.ghc_pkg, 'dump'])) File "/c/code/HEAD/testsuite/driver/testutil.py", line 25, in getStdout raise Exception("stderr from command: " + str(cmd_and_args)) Exception: stderr from command: ['"/c/code/HEAD/inplace/bin/ghc-pkg.exe"', 'dump'] make[1]: *** [../mk/test.mk:299: test] Error 1 make[1]: Leaving directory '/c/code/HEAD/testsuite/tests' make: *** [../mk/test.mk:315: fasttest] Error 2 make: Leaving directory '/c/code/HEAD/testsuite/tests' make: Entering directory '/c/code/HEAD/testsuite/tests/stage1' WARNING: cache is out of date: C:\code\HEAD\inplace\lib\package.conf.d\package.cache ghc will see an old view of this package db. Use 'ghc-pkg recache' to fix. ../../mk/ghc-config "/c/code/HEAD/inplace/bin/ghc-stage1.exe" >"../../mk/ghcconfig_c_code_HEAD_inplace_bin_ghc-stage1.exe.mk"; if [ $? != 0 ]; then rm -f "../../mk/ghcconfig_c_code_HEAD_inplace_bin_ghc-stage1.exe.mk"; exit 1; fi WARNING: cache is out of date: C:\code\HEAD\inplace\lib\package.conf.d\package.cache ghc will see an old view of this package db. Use 'ghc-pkg recache' to fix. # See Note [validate and testsuite speed] in toplevel Makefile. make SPEED=2 make[1]: Entering directory '/c/code/HEAD/testsuite/tests/stage1' WARNING: cache is out of date: C:\code\HEAD\inplace\lib\package.conf.d\package.cache ghc will see an old view of this package db. Use 'ghc-pkg recache' to fix. PYTHON="python3" "python3" ../../driver/runtests.py -e ghc_compiler_always_flags="'-dcore-lint -dcmm-lint -no-user-package-db -rtsopts -fno-warn-missed-specialisations -fshow-warning-groups -fdiagnostics-color=never -fno-diagnostics-show-caret -dno-debug-output'" -e config.compiler_debugged=True -e ghc_with_native_codegen=1 -e config.have_vanilla=True -e config.have_dynamic=False -e config.have_profiling=False -e ghc_with_threaded_rts=1 -e ghc_with_dynamic_rts=0 -e config.have_interp=False -e config.unregisterised=False -e config.ghc_dynamic_by_default=False -e config.ghc_dynamic=False -e ghc_with_smp=1 -e ghc_with_llvm=0 -e windows=True -e darwin=False -e config.in_tree_compiler=True --threads=5 -e config.cleanup=True -e config.local=False --rootdir=. --configfile=../../config/ghc -e 'config.confdir="../../config"' -e 'config.platform="x86_64-unknown-mingw32"' -e 'config.os="mingw32"' -e 'config.arch="x86_64"' -e 'config.wordsize="64"' -e 'config.timeout=int() or config.timeout' -e 'config.exeext=".exe"' -e 'config.top="/c/code/HEAD/testsuite"' --config 'compiler="/c/code/HEAD/inplace/bin/ghc-stage1.exe"' --config 'ghc_pkg="/c/code/HEAD/inplace/bin/ghc-pkg.exe"' --config 'haddock="/c/code/HEAD/inplace/bin/haddock.exe"' --config 'hp2ps="/c/code/HEAD/inplace/bin/hp2ps.exe"' --config 'hpc="/c/code/HEAD/inplace/bin/hpc.exe"' --config 'gs="gs"' --config 'timeout_prog="../../timeout/install-inplace/bin/timeout.exe"' -e "config.stage=1" --summary-file "../../../testsuite_summary_stage1.txt" --no-print-summary 1 \ \ \ \ \ \ -e config.speed="2" \ Traceback (most recent call last): File "../../driver/runtests.py", line 189, in <module> pkginfo = str(getStdout([config.ghc_pkg, 'dump'])) File "/c/code/HEAD/testsuite/driver/testutil.py", line 25, in getStdout raise Exception("stderr from command: " + str(cmd_and_args)) Exception: stderr from command: ['"/c/code/HEAD/inplace/bin/ghc-pkg.exe"', 'dump'] make[1]: *** [../../mk/test.mk:299: test] Error 1 make[1]: Leaving directory '/c/code/HEAD/testsuite/tests/stage1' make: *** [../../mk/test.mk:315: fasttest] Error 2 make: Leaving directory '/c/code/HEAD/testsuite/tests/stage1' ==== STAGE 1 TESTS ==== cat: testsuite_summary_stage1.txt: No such file or directory /c/code/HEAD$

5 8

Additional catch notes
by David Feuer 03 Mar '17

03 Mar '17

I dug a little further into what you tried to do with catch and where I think it went wrong. You can see my thoughts in the notes I added in D3263. It could even be possible to fix the problem for real by changing the DmdRes domain again. Originally, we broke it up into Diverges and Dunno. You added an additional ThrowsExn to mean "diverges or throws an exception". But I think a critical point in the domain, for this analysis, is "definitely does not throw an exception". If we have catch# m f s then we can speculatively evaluate/unbox only those expressions in (m s) that definitely don't throw exceptions (whether they succeed or diverge). One other thought: it might be worth considering a catchIO# primitive. This would catch exceptions thrown by raiseIO# but *not* by raise#. This could be made *much* stricter, I believe, if give raiseIO# a special place in the result domain. David

1 0

collectBindersPushingCo
by Simon Peyton Jones 01 Mar '17

01 Mar '17

David Thanks for moving my early-inline patch series to HEAD. You'll remember that I pushed this patch (below) to spj-early-inline2 Can you be sure to cherry-pick this one too? It's important and I don't see it in HEAD yet. I'm surprised that there isn't a validate failure (T9505 if memory serves - see attached). Simon commit 002192aa8df463ae945e8a94147cfc1d848f43a5 Author: Simon Peyton Jones <simonpj(a)microsoft.com> Date: Fri Feb 24 16:55:36 2017 +0000 Fix a nasty bug in CoreSubst.collectBindersPushingCo The bug wsa in the use of (mkNthCo 0) to get the argument part of a function coercion. Not so! Now (->) takes four arguments so that 0 should have been 2. Enough with magic numbers. I defined decomposeFunCo, and used it throughout. Much nicer now; and correct. The nete effect, incidentally, was that T9509 was failing to specialise. (And that was the initial reason for introducing collectBindersPushingCo in the first place.)

2 2