- ghc-devs - Haskell.org

JSON output of GHC Diagnostics
by Ben Bellick 10 Jul '23

10 Jul '23

Hey everyone, I am working on a summer of Haskell project to implement JSON output of GHC's diagnostics. I have begun working through some of the implementation details but have stumbled across a few road blocks and I wanted to get some feedback on. Discussion surrounding the plan can be found [here](https://github.com/haskellfoundation/tech-proposals/pull/50). In looking through the current implementation of the -ddump-json flag, I found a [note](https://gitlab.haskell.org/ghc/ghc/-/blob/master/compiler/GHC/Utils/L… which seems to indicate that a sensible (albeit invasive) approach is to alter the definition of [LogAction](https://gitlab.haskell.org/ghc/ghc/-/blob/master/compiler/GHC/Ut…, reproduced below: type LogAction = LogFlags -> MessageClass -> SrcSpan -> SDoc -> IO () So instead of taking in an SDoc, I could alter this signature to take a set of Diagnostics, though this may introduce other complications. In the first place, it seems log action is processing all of the diagnostics one at a time, though this particular JSON output should process all of them at once in order to place them all in a single JSON object. So, I am inclined to believe that this approach may not work. Another approach could be the one originally tried and mentioned in the note linked above, which is to keep track of all diagnostics in an IORef, and use this to produce a final JSON result at the end of GHC's execution. This approach seems invasive in a different way. Does anyone familiar with the handling of diagnostics throughout the compiler have any suggestions on how best to implement such a feature? You can find the work that I have done so far [here](https://gitlab.haskell.org/benbellick/ghc/-/compare/master...json-dia…. All I am really doing is checking if the new flag is set in [printMessages](https://gitlab.haskell.org/benbellick/ghc/-/compare/master..…. If it is, then I simply invoke the json function of the ToJson typeclass and use that to print the diagnostic. It is currently a bit messy, but I wanted to just see if the path that I am taking seems fruitful or if there are any obvious hurdles that I am not seeing. Thanks so much! Best, Ben Bellick

3 2

I can't build HEAD
by Simon Peyton Jones 10 Jul '23

10 Jul '23

in a clean HEAD build, including "git submodule update", I get this. Can anyone help? Simon | Run Ar Pack (Stage0 InTreeLibs): _build/stage0/libraries/ghc-heap/build/cmm/cbits/HeapPrim.o (and 15 more) => _build/stage0/libraries/ghc-heap/build/libHSghc-heap-9.9-inplace.a ar: creating _build/stage0/libraries/ghc-heap/build/libHSghc-heap-9.9-inplace.a /-----------------------------------------------------------------------------\ | Successfully built library 'ghc-heap' (Stage0 InTreeLibs, way v). | | Library: _build/stage0/libraries/ghc-heap/build/libHSghc-heap-9.9-inplace.a | | Library synopsis: Functions for walking GHC's heap. | \-----------------------------------------------------------------------------/ ]0;Running for 2m35s [2621/2966], predicted 47s (77%) ]0;Running for 2m40s [2621/2966], predicted 47s (77%) ]0;Running for 2m45s [2621/2966], predicted 47s (77%) | Run Ghc CompileHs (Stage0 InTreeLibs): libraries/containers/containers/src/Data/Sequence/Internal/Sorting.hs => _build/stage0/libraries/containers/containers/build/Data/Sequence/Internal/Sorting.o | Run GhcPkg Unregister (Stage0 GlobalLibs): process => none | Run GhcPkg Update (Stage0 InTreeLibs): _build/stage0/libraries/exceptions/inplace-pkg-config => none | Copy package 'exceptions' # cabal-copy (for _build/stage0/lib/package.conf.d/exceptions-0.10.7-inplace.conf) # cabal-configure (for _build/stage0/libraries/text/setup-config) | Run GhcPkg Recache (Stage0 InTreeLibs): none => none hadrian: Encountered missing or private dependencies: data-array-byte >=0.1 && <0.2 ]0;Finished in 2m47s ExitFailure 1 Build failed. make: *** [/home/simonpj/code/Makefile-spj:10: all] Error 1 simonpj@CDW-8FABODHF0V5:~/code/HEAD$

4 4

Re: I can't build HEAD
by Viktor Dukhovni 09 Jul '23

09 Jul '23

Spam detection software, running on the system "mail.haskell.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: On Sun, Jul 09, 2023 at 05:49:38PM +0100, Simon Peyton Jones wrote: > in a clean HEAD build, including "git submodule update", I get this. > > Can anyone help? Did you run "cabal update"? What is your boot compiler version? [...] Content analysis details: (5.8 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 5.0 UNWANTED_LANGUAGE_BODY BODY: Message written in an undesired language 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% [score: 0.4970]

1 0

GitLab CI happenings in July
by Bryan Richter 03 Jul '23

03 Jul '23

Hello, This is the first (and, perhaps, last[1]) monthly update on GitLab CI. This month in particular deserves its own little email for the following reasons: 1. Some of the Darwin runners recently spontaneously self-upgraded, introducing toolchain changes that broke CI. All the fixes are now on GHC's master branch. This leaves us with two choices: A) Re-enable the affected runners now. All current patches will have a 50% of failing CI because the old problems are still present. Users (you) can rebase your patches to avoid this problem. B) Wait before re-enabling the runners. All in-flight MRs have a better chance of getting green CI and/or organically getting rebased for other reasons. However, Darwin capacity would remain at 50% for longer, slowing down all pipelines. My current plan is to wait one week before re-enabling the runners, but ultimately it's not my call. Opinions welcome. 2. I will be on vacation from July 17 to July 28 (weeks 29 and 30). Please tell Marge to be good while I am away. 3. GitLab was recently upgraded. Please do not be alarmed by any UI changes. Enjoy! -Bryan [1]: Intuitively, I like the idea of giving monthly updates about GitLab CI. But I don't know if it will be practical or valuable. I'll take a look in a month to see if there's anything notable to write about again.

1 0

GitLab upgraded
by Ben Gamari 02 Jul '23

02 Jul '23

Hi all, This evening (EST) I performed a quick upgrade of gitlab.haskell.org. As a result, you will notice that the UI has changed quite a bit. This is due to a beta redesign of GitLab's navigation scheme. While I've found it relatively unobjectionable (and seemingly a bit more snappier), your mileage may vary. If you find the redesign particularly onerous, you can (for now) disable it by toggling the "New navigation" slider in your "user" menu (accessed by clicking on your avatar icon in the sidebar on the left). If you do find that reverting is necessary, please do raise an issue with upstream as I suspect that upstream will commit to the redesign in the next few releases. As always, if you find something isn't working as you would expect, don't hesitate to reach out. Cheers, - Ben

1 0

Final Call for Talks: Haskell Implementors' Workshop 2023
by Ryan Scott 01 Jul '23

01 Jul '23

The 2023 Haskell Implementors' Workshop deadline is just under one month away. We are looking forward to your talk submissions. Best, Ryan ================================== ACM SIGPLAN Haskell Implementors' Workshop https://icfp23.sigplan.org/home/hiw-2023 Seattle, Washington, United States, September 4, 2023 Co-located with ICFP 2023 https://icfp23.sigplan.org/ Important dates --------------- Deadline: July 4, 2023 (AoE) Notification: August 4, 2023 Workshop: September 4, 2023 The 15th Haskell Implementors' Workshop is to be held alongside ICFP 2023 this year in Seattle. It is a forum for people involved in the design and development of Haskell implementations, tools, libraries, and supporting infrastructure to share their work and to discuss future directions and collaborations with others. Talks and/or demos are proposed by submitting an abstract, and selected by a small program committee. There will be no published proceedings. The workshop will be informal and interactive, with open spaces in the timetable and room for ad-hoc discussion, demos, and short lightning talks. Scope and target audience ------------------------- It is important to distinguish the Haskell Implementors' Workshop from the Haskell Symposium which is also co-located with ICFP 2023. The Haskell Symposium is for the publication of Haskell-related research. In contrast, the Haskell Implementors' Workshop will have no proceedings -- although we will aim to make talk videos, slides, and presented data available with the consent of the speakers. The Implementors' Workshop is an ideal place to describe a Haskell extension, describe works-in-progress, demo a new Haskell-related tool, or even propose future lines of Haskell development. Members of the wider Haskell community are encouraged to attend the workshop -- we need your feedback to keep the Haskell ecosystem thriving. Students working with Haskell are especially encouraged to share their work. The scope covers any of the following topics. There may be some topics that people feel we've missed, so by all means submit a proposal even if it doesn't fit exactly into one of these buckets: * Compilation techniques * Language features and extensions * Type system implementation * Concurrency and parallelism: language design and implementation * Performance, optimisation and benchmarking * Virtual machines and run-time systems * Libraries and tools for development or deployment Talks ----- We invite proposals from potential speakers for talks and demonstrations. We are aiming for 20-minute talks with 5 minutes for questions and changeovers. We want to hear from people writing compilers, tools, or libraries, people with cool ideas for directions in which we should take the platform, proposals for new features to be implemented, and half-baked crazy ideas. Please submit a talk title and abstract of no more than 300 words. Submissions can be made via HotCRP at https://icfphiw23.hotcrp.com until July 4 (anywhere on earth). We will also have a lightning talks session. These have been very well received in recent years, and we aim to increase the time available to them. Lightning talks should be ~7mins and are scheduled on the day of the workshop. Suggested topics for lightning talks are to present a single idea, a work-in-progress project, a problem to intrigue and perplex Haskell implementors, or simply to ask for feedback and collaborators. Program Committee ----------------- * Gergő Érdi (Standard Chartered Bank) * Sebastian Graf (Karlsruhe Institute of Technology) * Wen Kokke (University of Strathclyde) * Ryan Scott (Galois, Inc.) * Rebecca Skinner (Mercury) * Li-yao Xia (University of Edinburgh) Contact ------- * Ryan Scott <ryan.gl.scott at gmail.com>

1 1

CI *sad face*
by Bryan Richter 30 Jun '23

30 Jun '23

Two things are negatively impacting GHC CI right now: Darwin runner capacity is down to one machine, since the other three are paused. The problem and solution are known[1], but until the fix is implemented in GHC, expect pipelines to get backed up. I will work on a patch this morning [1]: https://gitlab.haskell.org/ghc/ghc/-/issues/23561 The other problem is one I just noticed, and I don't have any good info about it yet. The symptom is that Marge batch merges are failing reliably. Three patches that do fine individually somehow cause a type error in the hadrian-ghc-in-ghci job when combined[2]. The only clue is the error itself, which complains of an out-of-scope data constructor "ArchJavaScript" in the file compiler/GHC/Driver/Main.hs. A cursory look at the individual patches doesn't shed any light. I just rebased all of them to see if I can shake the error out of them that way. Any knowledge that can be brought to bear would be appreciated [2]: https://gitlab.haskell.org/ghc/ghc/-/merge_requests/10745#note_507418 -Bryan

2 3

Distinct closure types vs. known infotables for stack frames
by Alexis King 28 Jun '23

28 Jun '23

Hello all, I am tinkering with the RTS again while trying to fix #23513 <https://gitlab.haskell.org/ghc/ghc/-/issues/23513>, and every time I touch the exceptions/continuations code, I find myself waffling about whether to introduce more closure types. I’d like to get a second opinion so I can stop changing my mind! Currently, we have distinct closure types for certain special stack frames, like CATCH_FRAME, ATOMICALLY_FRAME, and UNDERFLOW_FRAME. However, there are other special stack frames that *don’t* get their own closure types: there is no MASK_ASYNC_EXCEPTIONS_FRAME or PROMPT_FRAME. Instead, when code needs to recognize these frames on the stack, it just looks for a known infotable pointer. That is, instead of writing if (frame->header.info->i.type == PROMPT_FRAME) { ... } we write if (*frame == &stg_prompt_frame_info) { ... } which works out because there’s only one info table that’s used for all prompt frames. There are a handful of stack frames that are recognized in this way by some part of the RTS, but the criteria used to determine which frames get their own types and which don’t is not particularly clear. For some frames, like UPDATE_FRAME, the closure type is necessary because it is shared between several infotables. But other types, like CATCH_FRAME and UNDERFLOW_FRAME, are only ever used by precisely one infotable. I think one can make the following arguments for/against using separate closure types for these stack frames: - Pro: It’s helpful to have separate types for particularly special frames like UNDERFLOW_FRAME because it makes it easier to remember which special cases to handle when walking the stack. - Pro: Branching on stack frame closure types using switch is easier to read than comparing infotable pointers. - Con: Adding more closure types unnecessarily pollutes code that branches on closure types, like the garbage collector. - Con: Using special closure types for these frames might make it seem like they have some special layout when in fact they are just ordinary stack frames. Does anyone have any opinions about this? I’m personally okay with the status quo, but the inconsistency makes me constantly second-guess whether someone else might feel strongly that I ought to be doing things the other way! Thanks, Alexis

3 4

Re: Inquiry about Supporting RISC-V 32 in Haskell
by Moritz Angermann 27 Jun '23

27 Jun '23

Hi Shiwei, Let me try to draw up a more visual representation do the current pipelines over the weekend. That might also explain why I think the subset might work as the intermediate steps *do* carry register width. Cheers, Moritz On Thu, 8 Jun 2023 at 2:44 PM, 卢诗炜 <shiwei.lu(a)compiler-dev.com> wrote: > Moritz, > > Thank you for your detailed response. However, we think that RV32 is not a > subset of RV64, and that the instruction selection logic for RV32 and RV64 > may differ. Because RV32 and RV64 have different register widths, it is > sometimes necessary to use different instructions than RV64 to ensure > correct results. > > We plan to support RV32 in Native Code Generation. And we may draw > inspiration from your support for RV64. We do want to be able to support RV32I+MAF, > also include C extensions. > > Do you have any comments or suggestions? > > Thank you so much for your answer and help! > > Best regards， > Shiwei > > > > > 卢诗炜 > shiwei.lu(a)compiler-dev.com > > <https://lingxi.office.163.com/static_html/signature.html?id=694846303015866…> > 签名由网易灵犀办公 <https://hubble.netease.com/sl/aaagLd> 定制 > > > > Original: > > - From：moritz.angermann<moritz.angermann(a)gmail.com> > - Date：2023-06-08 09:59:38(中国(GMT+08:00)) > > > - To：卢诗炜<shiwei.lu(a)compiler-dev.com> > - Cc： > - Subject：Re: Inquiry about Supporting RISC-V 32 in Haskell > > > > 诗炜, > > This is a bit hard to answer. As GHC is a fairly distributed open source > project, everyone can effectively just contribute (by opening a Merge > Request on gitlab.haskell.org/ghc) and then the discussion around it > will start. There is no fixed plan as to what ends up in e.g. GHC 9.8 > (merge window will close June 16th), or even what GHC 9.10 will look like > or when it will be release (likely the merge window will close mid > December). > > GHC has various ways to generate code: > - Via a C backend (compile Haskell to C, use a C compiler to compile to > machine code). This backend is quite slow (compile time, and runtime) > - Via LLVM (comile Haskell to LLVM textual IR, then use LLVM's `opt` and > `llc` to compile it to machine code). This backend produces good performing > code, but is very slow to compile. > - Via Native Code Generation (this turns Haskell into assembly, and then > uses usually the CC compiler to just turn .S into .o). This has good > compile time performance, and often competitive runtime performance. > However this lacks for all supposed architectures proper SIMD support. > > The LLVM backend can _in theory_ compile to any LLVM supported target. > (The LLVM RV64 backend in GHC is that effectively). The Native Code > Generator (NCG), support x86_64, i686, aarch64, and soon rv64. There are > also powerpc, sparc and mips NCG backends, however the state of most cross > compilation targets are only on a best effort basis and are not tested in > CI. Since GHC 9.2 there are also JavaScript and WASM backends in GHC. > > If you just want to cross compile for RV32, going down the LLVM route > might be the easiest. > > _my_ current plans are to work on > - The RV64 NCG > - The linker/loader for ELF/RV64 > - aarch32 NCG > > For RV32, we are in the lucky position that the instruction set is > effectively just a subset of the RV64 instruction set. So we might be able > to request some of the RV64 backend, or even better make the RV64 backend a > superset of the RV32 backend. > > I assume you are looking to support RV32I+MAF? > > Happy to help with any follow up questions. > > Cheers, > Moritz > > On Thu, 8 Jun 2023 at 08:38, 卢诗炜 <shiwei.lu(a)compiler-dev.com> wrote: > >> Thank you for your prompt reply. We have seen the support for your team >> working for RV64 in the GHC. You've done a great job. >> >> >> >> We'd like to do what your team does for GHC by supporting new compile >> backends, like RV32, to contribute to the community. We are more focused >> on _cross compilation_ from x86_64 to RV32 on Linux. But we dont know >> much about GHC's current dynamics and plans, whether there is a need for >> this or whether support is being provided. >> >> Do we need to support RV32 for GHC? Or is there anything else you think >> we can contribute to? >> >> Looking forward to your reply, Thanks! >> >> Best regards， >> Shiwei >> >> >> 卢诗炜 >> shiwei.lu(a)compiler-dev.com >> >> <https://lingxi.office.163.com/static_html/signature.html?id=694846303015866…> >> 签名由网易灵犀办公 <https://hubble.netease.com/sl/aaagLd> 定制 >> >> >> >> Original: >> >> - From：moritz.angermann<moritz.angermann(a)gmail.com> >> - Date：2023-06-07 19:45:32 >> - To：卢诗炜<shiwei.lu(a)compiler-dev.com> >> - Cc： >> - Subject：Re: Inquiry about Supporting RISC-V 32 in Haskell >> >> 您好诗炜！ >> 对不起，我的中文不很好。写英语。 >> I assume you've found my email from the ghc source repo? Yes, I have >> extensive experience adding compiler backends to GHC, including GHC's >> internal static linker. >> Recently a friend and I have started working on RV64 support in GHC (See >> https://gitlab.haskell.org/ghc/ghc/-/merge_requests/10367) So we have >> some prior experience >> with RISC-V. >> >> I understand you want to have support for RV32 in ghc? Are you looking >> for _native_ RV32 support GHC the compiler running natively on RISC-V 32 >> hardware? Or are you >> primarily interested in _cross compilation_ to RV32 from e.g. RV64, >> x86_64, aarch64? >> >> Also which platform are you interested in? Linux? >> >> Happy to provide more concrete feedback based on your exact requirements >> and vision. Ultimately GHC is a community project and everyone can >> contribute. I can certainly >> provide guidance and assistance here. >> >> Cheers, >> Moritz >> >> On Wed, 7 Jun 2023 at 18:16, 卢诗炜 <shiwei.lu(a)compiler-dev.com> wrote: >> >>> Dear Moritz Angermann， >>> >>> Hello! I am writing on behalf of Hunan Compiler Technology Co., Ltd. to >>> inquire about the possibility of supporting RISC-V 32 in Haskell o >>> >>> r if you're supporting it >>> . We are a technology company based in China and we would like to >>> contribute to the Haskell community by providing support for this >>> architecture. >>> >>> As you may know, RISC-V is an open-source instruction set architecture >>> that is gaining popularity in the industry. It is important for us to >>> ensure that our products are compatible with this architecture, and we >>> believe that supporting RISC-V in Haskell would be a valuable contribution >>> to the community. >>> >>> >>> We are willing to work closely with the community to understand the >>> requirements and challenges of supporting RISC-V in Haskell. We have a team >>> of experienced engineers who are familiar with both Haskell and RISC-V, and >>> we are confident that we can provide high-quality support for this >>> architecture. >>> >>> >>> We would appreciate any guidance or feedback from the community on this >>> matter. Please let us know if there are any specific requirements or >>> challenges that we should be aware of. We look forward to working with the >>> Haskell community to support RISC-V. >>> >>> >>> Thank you for your time and consideration. >>> >>> >>> Sincerely, Shiwei LU, Hunan Compiler Technology Co., Ltd. >>> >>> >>> >>> <https://lingxi.office.163.com/static_html/signature.html?id=694846303015866…> >>> >>> >>> >>> >> >> > >

4 3

SSH on Gitlab
by Simon Peyton Jones 27 Jun '23

27 Jun '23

Is SSH working on gitlab.haskell.org? I'm getting this simonpj@CDW-8FABODHF0V5:~$ ssh -v git(a)gitlab.haskell.org OpenSSH_8.2p1 Ubuntu-4, OpenSSL 1.1.1f 31 Mar 2020 debug1: Reading configuration data /home/simonpj/.ssh/config debug1: Reading configuration data /etc/ssh/ssh_config debug1: /etc/ssh/ssh_config line 19: include /etc/ssh/ssh_config.d/*.conf matched no files debug1: /etc/ssh/ssh_config line 21: Applying options for * debug1: Connecting to gitlab.haskell.org [145.40.64.137] port 22. debug1: Connection established. debug1: identity file /home/simonpj/.ssh/id_rsa type 0 debug1: identity file /home/simonpj/.ssh/id_rsa-cert type -1 debug1: identity file /home/simonpj/.ssh/id_dsa type 1 debug1: identity file /home/simonpj/.ssh/id_dsa-cert type -1 debug1: identity file /home/simonpj/.ssh/id_ecdsa type -1 debug1: identity file /home/simonpj/.ssh/id_ecdsa-cert type -1 debug1: identity file /home/simonpj/.ssh/id_ecdsa_sk type -1 debug1: identity file /home/simonpj/.ssh/id_ecdsa_sk-cert type -1 debug1: identity file /home/simonpj/.ssh/id_ed25519 type 3 debug1: identity file /home/simonpj/.ssh/id_ed25519-cert type -1 debug1: identity file /home/simonpj/.ssh/id_ed25519_sk type -1 debug1: identity file /home/simonpj/.ssh/id_ed25519_sk-cert type -1 debug1: identity file /home/simonpj/.ssh/id_xmss type -1 debug1: identity file /home/simonpj/.ssh/id_xmss-cert type -1 debug1: Local version string SSH-2.0-OpenSSH_8.2p1 Ubuntu-4 At this point it hangs. Stackoverflow suggests <https://superuser.com/questions/1374076/what-does-it-mean-if-ssh-hangs-afte…>a server fault. But I'm on a new WLAN so I suppose there could be some bizarre filtering? Thanks Simon

4 6