- ghc-devs - Haskell.org

Note [Api annotations]
by Ömer Sinan Ağacan 20 Jul '16

20 Jul '16

I see some weird comments like -- - 'ApiAnnotation.AnnKeywordId' : 'ApiAnnotation.AnnOpen', -- 'ApiAnnotation.AnnVbar','ApiAnnotation.AnnComma', -- 'ApiAnnotation.AnnClose' -- For details on above see note [Api annotations] in ApiAnnotation in some files, but Note [Api annotations] in compiler/parser/ApiAnnotation.hs doesn't say anything about those comments. Can someone update the note to explain what are those comments for?

4 4

first unboxed sums patch is ready for reviews
by Ömer Sinan Ağacan 19 Jul '16

19 Jul '16

Hi all, I'm almost done with the unboxed sums patch and I'd like to get some reviews at this point. https://phabricator.haskell.org/D2259 Two key files in the patch are UnariseStg.hs and RepType.hs. For the example programs see files in testsuite/tests/unboxedsums/ In addition to any comments about the code and documentation, it'd be appreciated if you tell me about some potential uses of unboxed sums, example programs, edge cases etc. so that I can test it a bit more and make sure the generated code is good. Thanks, Omer

1 1

Parser changes for supporting top-level SCC annotations
by Ömer Sinan Ağacan 19 Jul '16

19 Jul '16

I'm trying to support SCCs at the top-level. The implementation should be trivial except the parsing part turned out to be tricky. Since expressions can appear at the top-level, after a {-# SCC ... #-} parser can't decide whether to reduce the token in `sigdecl` to generate a `(LHsDecl (Sig (SCCSig ...)))` or to keep shifting to parse an expression. As shifting is the default behavior when a shift/reduce conflict happens, it's always trying to parse an expression, which is always the wrong thing to do. Does anyone have any ideas on how to handle this? Motivation: Not having SCCs at the top level is becoming annoying real quick. For simplest cases, it's possible to do this transformation: f x y = ... => f = {-# SCC f #-} \x y -> ... However, it doesn't work when there's a `where` clause: f x y = <t is in scope> where t = ... => f = {-# SCC f #-} \x y -> <t is out of scope> where t = ... Or when we have a "equation style" definition: f (C1 ...) = ... f (C2 ...) = ... f (C3 ...) = ... ... (usual solution is to rename `f` to `f'` and define a new `f` with a `SCC`)

4 6

RE: [commit: ghc] wip/generics-flip: Flip around imports of GHC.Generics (cb12bdf)
by Simon Peyton Jones 18 Jul '16

18 Jul '16

I don’t object to this, but I suspect that it's just covering up some other bug. Simon -----Original Message----- From: ghc-commits [mailto:ghc-commits-bounces@haskell.org] On Behalf Of git(a)git.haskell.org Sent: 18 July 2016 14:57 To: ghc-commits(a)haskell.org Subject: [commit: ghc] wip/generics-flip: Flip around imports of GHC.Generics (cb12bdf) Repository : ssh://git@git.haskell.org/ghc On branch : wip/generics-flip Link : https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fghc.haskell… >--------------------------------------------------------------- commit cb12bdf942df5e61771d69bbb6049f3b23ed580c Author: Ben Gamari <ben(a)smart-cactus.org> Date: Mon Jul 18 15:54:16 2016 +0200 Flip around imports of GHC.Generics Previously we had, GHC.Generics imports GHC.Ptr Data.Monoid imports GHC.Generics Data.Foldable imports GHC.Generics Data.Foldable imports Data.Monoid Prelude imports Data.Foldable Unfortunately this meant that any program importing Prelude (essentially all programs) would end up pulling in GHC.Generics and GHC.Ptr unnecessarily. Hopefully helps #12367. >--------------------------------------------------------------- cb12bdf942df5e61771d69bbb6049f3b23ed580c libraries/base/Data/Foldable.hs | 36 ---------------------- libraries/base/Data/Monoid.hs | 19 +++++------- libraries/base/GHC/Generics.hs | 67 +++++++++++++++++++++++++++++++++++++++-- 3 files changed, 72 insertions(+), 50 deletions(-) Diff suppressed because of size. To see it, use: git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc cb12bdf942df5e61771d69bbb6049f3b23ed580c _______________________________________________ ghc-commits mailing list ghc-commits(a)haskell.org https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fmail.haskel…

2 1

Slow validate currently fails
by Ömer Sinan Ağacan 15 Jul '16

15 Jul '16

Hi all, Just wanted to say that HEAD (37aeff6) doesn't currently pass validate (in slow mode). See details below. ==== STAGE 2 TESTS ==== Unexpected results from: TEST="haddock.Cabal hpc_fork T4114c T4114d dynamic-paper" SUMMARY for test run started at Fri Jul 15 11:19:15 2016 UTC 0:43:36 spent to go through 5264 total tests, which gave rise to 21166 test cases, of which 3817 were skipped 197 had missing libraries 16928 expected passes 219 expected failures 0 caused framework failures 0 unexpected passes 4 unexpected failures 1 unexpected stat failures Unexpected failures: /tmp/ghctest-7VEJbb/test spaces/./dependent/should_compile/dynamic-paper.run dynamic-paper [exit code non-0] (profasm) /tmp/ghctest-7VEJbb/test spaces/./driver/T4114c.run T4114c [bad exit code] (ghci) /tmp/ghctest-7VEJbb/test spaces/./driver/T4114d.run T4114d [bad exit code] (ghci) /tmp/ghctest-7VEJbb/test spaces/../../libraries/hpc/tests/fork/hpc_fork.run hpc_fork [bad heap profile] (profasm) Unexpected stat failures: /tmp/ghctest-7VEJbb/test spaces/./perf/haddock/haddock.Cabal.run haddock.Cabal [stat not good enough] (normal) It validates in fast mode though (haven't tried the default mode).

1 0

Windows build
by Simon Peyton Jones 12 Jul '16

12 Jul '16

I've completed a successful build on my Surface Book! Thank you. One last glitch. I'm getting the validate failure bellow. No other test requires gcc in my path. GHC itself carefully navigates to its own private gcc. Do we really want this family of tests (half a dozen variants of T11223) to rely on some random gcc, which might or might not be the same as GHC is using? Shouldn't we use 'ghc foo.c'? Simon =====> T11223_simple_unused_duplicate_lib(normal) 3371 of 5211 [0, 6, 1] cd "/c/Users/simonpj/AppData/Local/Temp/ghctest-hFCtmi/test spaces/./rts/T11223/T11223_simple_unused_duplicate_lib.run" && $MAKE -s --no-print-directory t_11223_simple_unused_duplicate_lib Wrong exit code (expected 0 , actual 2 ) Stdout: Stderr: /bin/sh: gcc: command not found make[2]: *** [Makefile:42: t_11223_simple_unused_duplicate_lib] Error 127

3 3

Rethinking GHC's approach to managing proposals
by Ben Gamari 11 Jul '16

11 Jul '16

Hello everyone, Recently there has been a fair bit of discussion[1,2] around the mechanisms by which proposed changes to GHC are evaluated. While we have something of a formal proposal protocol [3], it is not clearly documented, inconsistently applied, and may be failing to serve a significant fraction of GHC's potential contributor pool. Over the last few weeks, I have been doing a fair amount of reading, thinking, and discussing to try to piece together a proposal scheme which better serves our community. The resulting proposal [4] is strongly inspired by the RFC process in place in the Rust community [5], the leaders of which have thought quite hard about fostering community growth and participation. While no process is perfect, I feel like the Rust process is a good starting point for discussion, offering enough structure to guide new contributors through the process while requiring only a modest investment of developer time. To get a sense for how well this will work in our community, I propose that we attempt to self-host the proposed process. To this end I have setup a ghc-proposals repository [6] and opened a pull request for discussion of the process proposal [4]. Let's see how this goes. Cheers, - Ben [1] https://www.reddit.com/r/haskell/comments/4oyxo2/blog_contributing_to_ghc/ [2] https://www.reddit.com/r/haskell/comments/4isua9/ghc_development_outsidein/ [3] https://ghc.haskell.org/trac/ghc/wiki/WorkingConventions/AddingFeatures [4] https://github.com/ghc-proposals/ghc-proposals/pull/1/files?short_path=14d6… [5] https://github.com/rust-lang/rfcs [6] https://github.com/ghc-proposals/ghc-proposals

3 2

T11758 testcase help needed
by Alex Dzyoba 11 Jul '16

11 Jul '16

Hi, all! I was working on #11758, which is about dropping binutils<2.17 hack, and while it was relatively easy to remove the hack itself, I'm not sure how to add a test case for it. As I understand, after removing the aforementioned hack, native codegen now shouldn't generate sign extension. So my question is how to test it? Should it be Cmm file that will be tested with `compile_cmp_asm` like memcpy in "codeGen/should_gen_asm/memcpy.cmm"? Or should I stick to the Haskell test? Thanks, Alex Dzyoba

3 2

What fixed this?
by Ben Gamari 11 Jul '16

11 Jul '16

Does anyone know which commit fixed the testcase in #12381 on master? This testcase currently fails on 8.0.1 and it would be nice if we could merge the fix for 8.0.2. Cheers, - Ben

1 0

testsuite: Test named X but want to use Y.hs as source
by Ömer Sinan Ağacan 10 Jul '16

10 Jul '16

I have some number of test programs that I compile and run as usual. I also want to run them using GHCi, with -fobject-code. So I tried this: def just_ghci( name, opts ): opts.only_ways = ['ghci'] test('unboxedsums1.ghci', just_ghci, compile_and_run, ['-fobject-code']) Now, I don't have a file named `unboxedsums1.ghci.hs`, I want to use `unboxedsums1.hs` and I already have a test named `unboxedsums1`. Any ideas how to do this? Thanks

1 0