- ghc-devs - Haskell.org

Re: [commit: ghc] wip/nested-cpr: Add a flag -fnested-cpr-off to conveniently test the effect of nested CPR (90529b1)
by Johan Tibell 04 Dec '13

04 Dec '13

Nitpick: don't we usually name these flags -fno-nested-cpr? On Wed, Dec 4, 2013 at 10:19 AM, <git(a)git.haskell.org> wrote: > Repository : ssh://git@git.haskell.org/ghc > > On branch : wip/nested-cpr > Link : > http://ghc.haskell.org/trac/ghc/changeset/90529b15c02ef03dcece13c267b76d470… > > >--------------------------------------------------------------- > > commit 90529b15c02ef03dcece13c267b76d470941b808 > Author: Joachim Breitner <mail(a)joachim-breitner.de> > Date: Wed Dec 4 09:14:26 2013 +0000 > > Add a flag -fnested-cpr-off to conveniently test the effect of nested > CPR > > > >--------------------------------------------------------------- > > 90529b15c02ef03dcece13c267b76d470941b808 > compiler/basicTypes/Demand.lhs | 28 +++++++++++++++++++--------- > compiler/main/StaticFlags.hs | 9 +++++++-- > 2 files changed, 26 insertions(+), 11 deletions(-) > > diff --git a/compiler/basicTypes/Demand.lhs > b/compiler/basicTypes/Demand.lhs > index 557a9bd..e955195 100644 > --- a/compiler/basicTypes/Demand.lhs > +++ b/compiler/basicTypes/Demand.lhs > @@ -791,20 +791,29 @@ botRes = Diverges > maxCPRDepth :: Int > maxCPRDepth = 3 > > +-- This is the depth we use with -fnested-cpr-off, in order > +-- to get precisely the same behaviour as before introduction of nested > cpr > +-- -fnested-cpr-off can eventually be removed if nested cpr is deemd to be > +-- a good thing always. > +flatCPRDepth :: Int > +flatCPRDepth = 1 > + > -- With nested CPR, DmdResult can be arbitrarily deep; consider e.g. the > -- DmdResult of repeat > -- > -- So we need to forget information at a certain depth. We do that at all > points > -- where we are building RetCon constructors. > -cutDmdResult :: Int -> DmdResult -> DmdResult > -cutDmdResult 0 _ = topRes > -cutDmdResult _ Diverges = Diverges > -cutDmdResult n (Converges c) = Converges (cutCPRResult n c) > -cutDmdResult n (Dunno c) = Dunno (cutCPRResult n c) > - > cutCPRResult :: Int -> CPRResult -> CPRResult > -cutCPRResult _ NoCPR = NoCPR > +cutCPRResult 0 _ = NoCPR > +cutCPRResult _ NoCPR = NoCPR > cutCPRResult n (RetCon tag rs) = RetCon tag (map (cutDmdResult (n-1)) rs) > + where > + cutDmdResult :: Int -> DmdResult -> DmdResult > + cutDmdResult 0 _ = topRes > + cutDmdResult _ Diverges = Diverges > + cutDmdResult n (Converges c) = Converges (cutCPRResult n c) > + cutDmdResult n (Dunno c) = Dunno (cutCPRResult n c) > + > > -- Forget that something might converge for sure > divergeDmdResult :: DmdResult -> DmdResult > @@ -819,8 +828,9 @@ forgetCPR (Dunno _) = Dunno NoCPR > > cprConRes :: ConTag -> [DmdType] -> CPRResult > cprConRes tag arg_tys > - | opt_CprOff = NoCPR > - | otherwise = cutCPRResult maxCPRDepth $ RetCon tag (map get_res > arg_tys) > + | opt_CprOff = NoCPR > + | opt_NestedCprOff = cutCPRResult flatCPRDepth $ RetCon tag (map > get_res arg_tys) > + | otherwise = cutCPRResult maxCPRDepth $ RetCon tag (map > get_res arg_tys) > where > get_res :: DmdType -> DmdResult > get_res (DmdType _ [] r) = r -- Only for data-typed arguments! > diff --git a/compiler/main/StaticFlags.hs b/compiler/main/StaticFlags.hs > index 01dc3b7..feb7235 100644 > --- a/compiler/main/StaticFlags.hs > +++ b/compiler/main/StaticFlags.hs > @@ -27,6 +27,7 @@ module StaticFlags ( > -- optimisation opts > opt_NoStateHack, > opt_CprOff, > + opt_NestedCprOff, > opt_NoOptCoercion, > > -- For the parser > @@ -140,7 +141,8 @@ flagsStaticNames :: [String] > flagsStaticNames = [ > "fno-state-hack", > "fno-opt-coercion", > - "fcpr-off" > + "fcpr-off", > + "fnested-cpr-off" > ] > > -- We specifically need to discard static flags for clients of the > @@ -195,10 +197,13 @@ opt_NoDebugOutput = lookUp (fsLit > "-dno-debug-output") > opt_NoStateHack :: Bool > opt_NoStateHack = lookUp (fsLit "-fno-state-hack") > > --- Switch off CPR analysis in the new demand analyser > +-- Switch off CPR analysis in the demand analyser > opt_CprOff :: Bool > opt_CprOff = lookUp (fsLit "-fcpr-off") > > +opt_NestedCprOff :: Bool > +opt_NestedCprOff = lookUp (fsLit "-fnested-cpr-off") > + > opt_NoOptCoercion :: Bool > opt_NoOptCoercion = lookUp (fsLit "-fno-opt-coercion") > > > _______________________________________________ > ghc-commits mailing list > ghc-commits(a)haskell.org > http://www.haskell.org/mailman/listinfo/ghc-commits >

2 1

arising from the dependency ... in the instance declaration
by Joachim Breitner 03 Dec '13

03 Dec '13

Hi, I have an error message, and I’m looking for code that produces it (how is that for a change...) While fixing https://ghc.haskell.org/trac/ghc/ticket/8576 I’d like to clean up some error reporting in FunDeps.lhs, in particular code that is involved in producing errors like Couldn't match type 'False with 'True When using functional dependencies to combine And 'False 'False 'False, arising from the dependency `a b -> c' in the instance declaration in `UnitTyped.Units' And 'False 'False 'True, arising from a use of `+' at <interactive>:14:7 In the expression: meter + second In an equation for `it': it = meter + second but unfortunately, the test suite does _not_ contain any code that creates this error message. Also, the results obtained from googling for that error message yield either no code, or only unhelpful code fragments, or code that produces a different error message with current HEAD. Unfortunately, I cannot produce code that triggers it. Does anyone have code lying around that triggers that error message? Also: I found code that had this kind of error message in 7.6, e.g. the attached code’s error changed from FunDepError.hs:86:27: Couldn't match type `F a1' with `U' When using functional dependencies to combine UpdateR (xs :> s) (S n) t (xs' :> s), arising from the dependency xs n t -> xs' in the instance declaration at FunDepError.hs:54:10 UpdateR ((xs' :> F a0) :> F a1) (S O) U ((jj0 :> U) :> U), arising from a use of `var' at FunDepError.hs:86:27-29 In the expression: var a In the first argument of `lam', namely `(\ b -> var a)' (sorry for not finding something simpler) to FunDepError.hs:86:5: No instance for (Consume xs' jj) arising from a use of ‛lam’ Possible fix: add (Consume xs' jj) to the context of the inferred type of x :: LLC t xs' jj (a :-> (a1 :-> a)) In the expression: lam (\ a -> lam (\ b -> var a)) In an equation for ‛x’: x = lam (\ a -> lam (\ b -> var a)) FunDepError.hs:86:27: No instance for (UpdateR ((xs' :> F a) :> F a1) (S O) U ((jj :> U) :> U)) arising from a use of ‛var’ In the expression: var a In the first argument of ‛lam’, namely ‛(\ b -> var a)’ In the expression: lam (\ b -> var a) Is that desired or a regression? Greetings, Joachim -- Joachim “nomeata” Breitner mail(a)joachim-breitner.de • http://www.joachim-breitner.de/ Jabber: nomeata(a)joachim-breitner.de • GPG-Key: 0x4743206C Debian Developer: nomeata(a)debian.org

2 3

Getting Involved
by Blair Archibald 03 Dec '13

03 Dec '13

Hi, I'm looking to get involved working on GHC - I've been using Haskell for quite a while now and thought I'd give back to the community. Bit about me: I'm Blair an (4th year) Undergraduate at the University of Glasgow and my main interests at the moment are Functional Programming, Runtime systems (mainly memory management/GC work) and Transactional Memory (making GHC a great place to be!) I've noticed that there is talk of adding a better flags parser to the RTS and this seems like a good place to start (less likely to break things!). Ticket: #4243 Is anyone currently working in this area or have plans to start work in this area? Many thanks, Blair

6 7

Can cardinality analysis subsume strictness analysis
by Joachim Breitner 02 Dec '13

02 Dec '13

Hi, after playing a bit with the Demand analyser and trying debug tricky bugs (#8569), I begin to wonder: Can cardinality analysis subsume strictness analysis? Not directly, obviously, but if we change data Count = One | Many to data Count = AtMostOne | ExactlyOne | AtLeastOne | Many (or some other form that would allow us to express all possible intervals in {0,1,∞}), would the demand and cardinality analysis then not subsume strictness, given that: A value is used strictly if is definitely used at least once? That might simplify the Demand.lhs code, and also the demand signatures, quite a bit, because currently it carries strictness and demand data around separately, duplicating lots of stuff. Greetings, Joachim -- Joachim “nomeata” Breitner mail(a)joachim-breitner.de • http://www.joachim-breitner.de/ Jabber: nomeata(a)joachim-breitner.de • GPG-Key: 0x4743206C Debian Developer: nomeata(a)debian.org

1 1

RE: [commit: ghc] master: Respect the ordering of -package directives (574ccfa)
by Simon Peyton-Jones 02 Dec '13

02 Dec '13

Patrick Thanks! When you do something subtle like change 'foldM' to 'foldrM', could you add a comment to point out the subtlety? After all, by definition this was something that someone else missed. Simon | -----Original Message----- | From: ghc-commits [mailto:ghc-commits-bounces@haskell.org] On Behalf Of | git(a)git.haskell.org | Sent: 02 December 2013 02:39 | To: ghc-commits(a)haskell.org | Subject: [commit: ghc] master: Respect the ordering of -package | directives (574ccfa) | | Repository : ssh://git@git.haskell.org/ghc | | On branch : master | Link : | http://ghc.haskell.org/trac/ghc/changeset/574ccfa231ca05d03d1da9d31e5bc | 81e74cc5e1e/ghc | | >--------------------------------------------------------------- | | commit 574ccfa231ca05d03d1da9d31e5bc81e74cc5e1e | Author: Patrick Palka <patrick(a)parcs.ath.cx> | Date: Tue Nov 26 11:46:59 2013 -0500 | | Respect the ordering of -package directives | | | >--------------------------------------------------------------- | | 574ccfa231ca05d03d1da9d31e5bc81e74cc5e1e | compiler/main/Packages.lhs | 15 ++++++++------- | 1 file changed, 8 insertions(+), 7 deletions(-) | | diff --git a/compiler/main/Packages.lhs b/compiler/main/Packages.lhs | index aefb536..df5eddb 100644 | --- a/compiler/main/Packages.lhs | +++ b/compiler/main/Packages.lhs | @@ -59,6 +59,7 @@ import System.FilePath as FilePath | import qualified System.FilePath.Posix as FilePath.Posix | import Control.Monad | import Data.Char (isSpace) | +import Data.Foldable (foldrM) | import Data.List as List | import Data.Map (Map) | import qualified Data.Map as Map | @@ -980,7 +981,7 @@ getPreloadPackagesAnd dflags pkgids = | preload = preloadPackages state | pairs = zip pkgids (repeat Nothing) | in do | - all_pkgs <- throwErr dflags (foldM (add_package pkg_map ipid_map) | preload pairs) | + all_pkgs <- throwErr dflags (foldrM (add_package pkg_map ipid_map) | preload pairs) | return (map (getPackageDetails state) all_pkgs) | | -- Takes a list of packages, and returns the list with dependencies | included, | @@ -1003,15 +1004,15 @@ closeDepsErr :: PackageConfigMap | -> Map InstalledPackageId PackageId | -> [(PackageId,Maybe PackageId)] | -> MaybeErr MsgDoc [PackageId] | -closeDepsErr pkg_map ipid_map ps = foldM (add_package pkg_map | ipid_map) [] ps | +closeDepsErr pkg_map ipid_map ps = foldrM (add_package pkg_map | ipid_map) [] ps | | -- internal helper | add_package :: PackageConfigMap | -> Map InstalledPackageId PackageId | - -> [PackageId] | -> (PackageId,Maybe PackageId) | + -> [PackageId] | -> MaybeErr MsgDoc [PackageId] | -add_package pkg_db ipid_map ps (p, mb_parent) | +add_package pkg_db ipid_map (p, mb_parent) ps | | p `elem` ps = return ps -- Check if we've already added this | package | | otherwise = | case lookupPackage pkg_db p of | @@ -1019,12 +1020,12 @@ add_package pkg_db ipid_map ps (p, mb_parent) | missingDependencyMsg mb_parent) | Just pkg -> do | -- Add the package's dependents also | - ps' <- foldM add_package_ipid ps (depends pkg) | + ps' <- foldrM add_package_ipid ps (depends pkg) | return (p : ps') | where | - add_package_ipid ps ipid@(InstalledPackageId str) | + add_package_ipid ipid@(InstalledPackageId str) ps | | Just pid <- Map.lookup ipid ipid_map | - = add_package pkg_db ipid_map ps (pid, Just p) | + = add_package pkg_db ipid_map (pid, Just p) ps | | otherwise | = Failed (missingPackageMsg str <> missingDependencyMsg | mb_parent) | | | _______________________________________________ | ghc-commits mailing list | ghc-commits(a)haskell.org | http://www.haskell.org/mailman/listinfo/ghc-commits

2 1

Re: [commit: testsuite] master: Explain skipping compiler-perf tests when debugging is on (14958ae)
by Simon Marlow 02 Dec '13

02 Dec '13

Actually this isn't quite right. compiler_debugged() is true when GhcDebugged=YES in the build system, and GhcDebugged controls whether GHC is compiled with -debug or not. That is, compiler_debugged() tells us whether the compiler was compiled with -debug, not -DDEBUG. The -debug flag links in the debug RTS and doesn't change allocation or heap residency, whereas -DDEBUG enables assertions in the compiler and *does* change allocation and heap residency. It looks like we need another predicate to tell us whether GHC was compiled with -DDEBUG or not. Would you mind backing out these changes in the meantime? Cheers, Simon On 28/11/13 15:55, git(a)git.haskell.org wrote: > Repository : ssh://git@git.haskell.org/testsuite > > On branch : master > Link : http://ghc.haskell.org/trac/ghc/changeset/14958ae02b99bafc06288493d186b9313… > >> --------------------------------------------------------------- > > commit 14958ae02b99bafc06288493d186b9313ee8c4b9 > Author: Joachim Breitner <mail(a)joachim-breitner.de> > Date: Thu Nov 28 15:56:16 2013 +0000 > > Explain skipping compiler-perf tests when debugging is on > > >> --------------------------------------------------------------- > > 14958ae02b99bafc06288493d186b9313ee8c4b9 > driver/testlib.py | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/driver/testlib.py b/driver/testlib.py > index bdb91b8..8c8c60d 100644 > --- a/driver/testlib.py > +++ b/driver/testlib.py > @@ -291,6 +291,8 @@ def _compiler_stats_num_field( name, opts, field, expecteds ): > if field in opts.compiler_stats_range_fields: > framework_fail(name, 'duplicate-numfield', 'Duplicate ' + field + ' num_field check') > > + # Compiler performance numbers change when debugging is on, making the results > + # useless and confusing. Therefore, skip if debugging is on. > if compiler_debugged(): > skip(name, opts) > > > _______________________________________________ > ghc-commits mailing list > ghc-commits(a)haskell.org > http://www.haskell.org/mailman/listinfo/ghc-commits >

2 3

Re: Getting Involved
by Jan Stolarek 02 Dec '13

02 Dec '13

Herbert, Austin, right, I didn't notice link to Newcomers is on the "Working on GHC" page. I rearranged it slightly by reversing first three steps. So link to Newcomers is now first on the list and I think it might stay that way. Link to "Working on GHC" is also in the second paragraph of the main wiki page, so I think we're good. As for the sidebar I'm using it on a regular basis although I feel some links could be removed: Documentation -> Repositories; Debugging; View Tickets -> By Milestone; By OS; By Architecture; But that's only my opinion - I'm CCing ghc-devs so others can chime in. If we could somehow track how often each link is used that could be a valuable information. Not sure if it can be done. Janek Dnia niedziela, 1 grudnia 2013, Herbert Valerio Riedel napisał: > On 2013-12-01 at 09:00:21 +0100, Jan Stolarek wrote: > >> perhaps a direct link in the sidebar or maybe even a link on the front > >> page in Developer Documentation section would be appropriate! > > > > I added link to Newcomers page at the main page of Commentary. > > btw, I'm confused a bit... there's already a rather obvious > > "Joining In"->"Working on GHC" link in the side-bar, which points to > > https://ghc.haskell.org/trac/ghc/wiki/WorkingConventions > > which then points you to the steps that are expected from newcomers, > including the 'Newcomers' page as the 3rd step; once could maybe just > add more emphasis to the 3rd step so that it visually stands out better > (e.g. via [2] or [3]) > > I'm just worried that cluttering the side-bar[1] with a redundant link > may make it less useful. > > > Don't have the permissions to add it to the sidebar though. > > ...the reason is btw, that it's a hacked in HTML fragment that's part of > the custom Trac stylesheet mod for GHC; it can't be edited via the > web-UI. > > > > [1]: which, personally, I find kinda overloaded and redundant which > makes me wonder if it's really that useful in its current form; > > > [2]: https://ghc.haskell.org/trac/ghc/wiki/WikiBoxes > > [3]: https://ghc.haskell.org/trac/ghc/wiki/WikiIcons

2 1

build errors
by Kazu Yamamoto 29 Nov '13

29 Nov '13

Hi, I cannot build GHC head on Linux and Mac (Mavericks) today: compiler/typecheck/TcEvidence.lhs:152:16: Not in scope: data constructor `ASSERT2' compiler/typecheck/TcEvidence.lhs:174:5: Not in scope: data constructor `ASSERT2' compiler/typecheck/TcEvidence.lhs:489:15: Not in scope: data constructor `ASSERT2' compiler/typecheck/TcEvidence.lhs:712:5: Not in scope: data constructor `ASSERT2' make[1]: *** [compiler/stage1/build/TcEvidence.o] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [all] Error 2 --Kazu

4 5

RE: [commit: testsuite] master: Summarily skip compiler_perf tests when DEBUG is on (715e313)
by Simon Peyton-Jones 28 Nov '13

28 Nov '13

Good! but please add a comment to explain why! The code is fully of mysterious un-commented things like this. Simon | -----Original Message----- | From: ghc-commits [mailto:ghc-commits-bounces@haskell.org] On Behalf Of | git(a)git.haskell.org | Sent: 28 November 2013 14:19 | To: ghc-commits(a)haskell.org | Subject: [commit: testsuite] master: Summarily skip compiler_perf tests | when DEBUG is on (715e313) | | Repository : ssh://git@git.haskell.org/testsuite | | On branch : master | Link : | http://ghc.haskell.org/trac/ghc/changeset/715e313d84f4e919e12c6bba6cd646 | e488cffa74/testsuite | | >--------------------------------------------------------------- | | commit 715e313d84f4e919e12c6bba6cd646e488cffa74 | Author: Joachim Breitner <mail(a)joachim-breitner.de> | Date: Thu Nov 28 14:17:35 2013 +0000 | | Summarily skip compiler_perf tests when DEBUG is on | | by ensuring this in the test runner. | | | >--------------------------------------------------------------- | | 715e313d84f4e919e12c6bba6cd646e488cffa74 | driver/testlib.py | 3 +++ | 1 file changed, 3 insertions(+) | | diff --git a/driver/testlib.py b/driver/testlib.py | index ed7d02f..bdb91b8 100644 | --- a/driver/testlib.py | +++ b/driver/testlib.py | @@ -291,6 +291,9 @@ def _compiler_stats_num_field( name, opts, field, | expecteds ): | if field in opts.compiler_stats_range_fields: | framework_fail(name, 'duplicate-numfield', 'Duplicate ' + field | + ' num_field check') | | + if compiler_debugged(): | + skip(name, opts) | + | for (b, expected, dev) in expecteds: | if b: | opts.compiler_stats_range_fields[field] = (expected, dev) | | _______________________________________________ | ghc-commits mailing list | ghc-commits(a)haskell.org | http://www.haskell.org/mailman/listinfo/ghc-commits

1 0

RE: [commit: testsuite] master: Update some perf results for master (4afbacc)
by Simon Peyton-Jones 28 Nov '13

28 Nov '13

Wait. Are you really increasing "bytes allocated" from 97M to 237M? That's a big change, and in an important number. Do you know why? Simon | -----Original Message----- | From: ghc-commits [mailto:ghc-commits-bounces@haskell.org] On Behalf Of | git(a)git.haskell.org | Sent: 28 November 2013 12:36 | To: ghc-commits(a)haskell.org | Subject: [commit: testsuite] master: Update some perf results for | master (4afbacc) | | Repository : ssh://git@git.haskell.org/testsuite | | On branch : master | Link : | http://ghc.haskell.org/trac/ghc/changeset/4afbacc299d843eb632df1f71eee2 | c91746c85a8/testsuite | | >--------------------------------------------------------------- | | commit 4afbacc299d843eb632df1f71eee2c91746c85a8 | Author: Joachim Breitner <mail(a)joachim-breitner.de> | Date: Thu Nov 28 12:36:15 2013 +0000 | | Update some perf results for master | | | >--------------------------------------------------------------- | | 4afbacc299d843eb632df1f71eee2c91746c85a8 | tests/perf/compiler/all.T | 11 ++++++----- | tests/perf/space_leaks/all.T | 2 +- | 2 files changed, 7 insertions(+), 6 deletions(-) | | diff --git a/tests/perf/compiler/all.T b/tests/perf/compiler/all.T | index a580bf9..759b5d0 100644 | --- a/tests/perf/compiler/all.T | +++ b/tests/perf/compiler/all.T | @@ -344,10 +344,11 @@ test('T5837', | test('T6048', | [ only_ways(['optasm']), | compiler_stats_num_field('bytes allocated', | - [(wordsize(32), 48887164, 10), | - # prev: 38000000 (x86/Linux) | - # 2012-10-08: 48887164 (x86/Linux) | - (wordsize(64), 97247032, 10)]) | - # 18/09/2012 97247032 amd64/Linux | + [(wordsize(32), 48887164, 10), | + # prev: 38000000 (x86/Linux) | + # 2012-10-08: 48887164 (x86/Linux) | + (wordsize(64), 237077056, 10)]) | + # 18/09/2012 97247032 amd64/Linux | + # 2013-11-26: 237077056 amd64/Linux | ], | compile,['']) | diff --git a/tests/perf/space_leaks/all.T | b/tests/perf/space_leaks/all.T | index a1fd641..ac60c8f 100644 | --- a/tests/perf/space_leaks/all.T | +++ b/tests/perf/space_leaks/all.T | @@ -6,7 +6,7 @@ test('space_leak_001', | # 5 (x86/Linux) | [stats_num_field('peak_megabytes_allocated', (4, 1)), | stats_num_field('max_bytes_used', | - [(wordsize(64), 440000, 10), | + [(wordsize(64), 440000, 15), | # 440224 (amd64/Linux) | # 417016 (x86/OS X) | # 415672 (x86/Windows) | | _______________________________________________ | ghc-commits mailing list | ghc-commits(a)haskell.org | http://www.haskell.org/mailman/listinfo/ghc-commits

3 6