- ghc-devs - Haskell.org

[PATCH] add better support for Raspberry Pi board
by Karel Gardas 29 Jan '13

29 Jan '13

This patch adds support for Raspberry Pi board. The board is based on Broadcom BCM2835, which includes ARM1176JZF-S CPU core. The core is classical ARM11 so implementing ARMv6 ISA, but also provides VFPv2 FPU unit. As this looks like fairly popular hardware, in this patch we assume detected ARMv6 hardware to support VFPv2. Also as Raspberry Pi is very commonly used with hard-float ABI Linux distribution, the patch relaxes a condition of "hard-float support for ARMv7 only" to any general ARM core. --- aclocal.m4 | 2 +- compiler/main/DriverPipeline.hs | 9 ++++++--- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/aclocal.m4 b/aclocal.m4 index edbe389..b23568f 100644 --- a/aclocal.m4 +++ b/aclocal.m4 @@ -369,7 +369,7 @@ AC_DEFUN([GET_ARM_ISA], [AC_DEFINE(arm_HOST_ARCH_PRE_ARMv7, 1, [ARM pre v7]) changequote(, )dnl ARM_ISA=ARMv6 - ARM_ISA_EXT="[]" + ARM_ISA_EXT="[VFPv2]" changequote([, ])dnl ], [changequote(, )dnl diff --git a/compiler/main/DriverPipeline.hs b/compiler/main/DriverPipeline.hs index c24bb51..81d0bc0 100644 --- a/compiler/main/DriverPipeline.hs +++ b/compiler/main/DriverPipeline.hs @@ -1454,14 +1454,17 @@ runPhase LlvmLlc input_fn dflags else if (elem VFPv3D16 ext) then ["-mattr=+v7,+vfp3,+d16"] else [] + ArchARM ARMv6 ext _ -> if (elem VFPv2 ext) + then ["-mattr=+v6,+vfp2"] + else ["-mattr=+v6"] _ -> [] -- On Ubuntu/Debian with ARM hard float ABI, LLVM's llc still -- compiles into soft-float ABI. We need to explicitly set abi -- to hard abiOpts = case platformArch (targetPlatform dflags) of - ArchARM ARMv7 _ HARD -> ["-float-abi=hard"] - ArchARM ARMv7 _ _ -> [] - _ -> [] + ArchARM _ _ HARD -> ["-float-abi=hard"] + ArchARM _ _ _ -> [] + _ -> [] sseOpts | isSse4_2Enabled dflags = ["-mattr=+sse42"] | isSse2Enabled dflags = ["-mattr=+sse2"] -- 1.7.3.2

2 5

rnfail055
by Simon Marlow 29 Jan '13

29 Jan '13

This test has been failing for a couple of days or so, anyone know why? Actual stderr output differs from expected: --- ./rename/should_fail/rnfail055.stderr 2013-01-07 08:47:29.856696930 +0000 +++ ./rename/should_fail/rnfail055.comp.stderr 2013-01-29 09:51:26.450096724 +0000 @@ -24,12 +24,12 @@ Type constructor `T1' has conflicting definitions in the module and its hs-boot file Main module: data T1 a b No C type associated - RecFlag Recursive + RecFlag Recursive, Promotable = T1 :: forall a b. [b] -> [a] -> T1 a b Stricts: _ _ FamilyInstance: none Boot file: data T1 a b No C type associated - RecFlag NonRecursive + RecFlag NonRecursive, Promotable = T1 :: forall a b. [a] -> [b] -> T1 a b Stricts: _ _ FamilyInstance: none @@ -37,12 +37,12 @@ Type constructor `T2' has conflicting definitions in the module and its hs-boot file Main module: data Eq b => T2 a b No C type associated - RecFlag Recursive + RecFlag Recursive, Promotable = T2 :: forall a b. a -> T2 a b Stricts: _ FamilyInstance: none Boot file: data Eq a => T2 a b No C type associated - RecFlag NonRecursive + RecFlag NonRecursive, Promotable = T2 :: forall a b. a -> T2 a b Stricts: _ FamilyInstance: none @@ -56,12 +56,12 @@ Type constructor `T5' has conflicting definitions in the module and its hs-boot file Main module: data T5 a No C type associated - RecFlag Recursive + RecFlag Recursive, Promotable = T5 :: forall a. a -> T5 a Stricts: _ Fields: field5 FamilyInstance: none Boot file: data T5 a No C type associated - RecFlag NonRecursive + RecFlag NonRecursive, Promotable = T5 :: forall a. a -> T5 a Stricts: _ FamilyInstance: none @@ -69,12 +69,12 @@ Type constructor `T6' has conflicting definitions in the module and its hs-boot file Main module: data T6 No C type associated - RecFlag Recursive + RecFlag Recursive, Not promotable = T6 :: Int -> T6 Stricts: _ FamilyInstance: none Boot file: data T6 No C type associated - RecFlag NonRecursive + RecFlag NonRecursive, Not promotable = T6 :: Int -> T6 HasWrapper Stricts: ! FamilyInstance: none @@ -82,12 +82,12 @@ Type constructor `T7' has conflicting definitions in the module and its hs-boot file Main module: data T7 a No C type associated - RecFlag Recursive + RecFlag Recursive, Promotable = T7 :: forall a a1. a1 -> T7 a Stricts: _ FamilyInstance: none Boot file: data T7 a No C type associated - RecFlag NonRecursive + RecFlag NonRecursive, Promotable = T7 :: forall a b. a -> T7 a Stricts: _ FamilyInstance: none *** unexpected failure for rnfail055(normal)

2 1

Re: Size of crosscompiled exectuable
by Simon Marlow 29 Jan '13

29 Jan '13

On 28/01/13 20:05, Nathan Hüsken wrote: > With > > SplitObjs = YES > > I get > > on the commandline: Warning: ignoring -fsplit-objs > "rm" -f libraries/ghc-prim/dist-install/build/libHSghc-prim-0.3.1.0.a > libraries/ghc-prim/dist-install/build/libHSghc-prim-0.3.1.0.a.contents > /usr/bin/find libraries/ghc-prim/dist-install/build/GHC/Classes_o_split > libraries/ghc-prim/dist-install/build/GHC/CString_o_split > libraries/ghc-prim/dist-install/build/GHC/Debug_o_split > libraries/ghc-prim/dist-install/build/GHC/Magic_o_split > libraries/ghc-prim/dist-install/build/GHC/PrimopWrappers_o_split > libraries/ghc-prim/dist-install/build/GHC/IntWord64_o_split > libraries/ghc-prim/dist-install/build/GHC/Tuple_o_split > libraries/ghc-prim/dist-install/build/GHC/Types_o_split -name '*.o' > -print >> > libraries/ghc-prim/dist-install/build/libHSghc-prim-0.3.1.0.a.contents > /usr/bin/find: > `libraries/ghc-prim/dist-install/build/GHC/Classes_o_split': No such > file or directory > /usr/bin/find: > `libraries/ghc-prim/dist-install/build/GHC/CString_o_split': No such > file or directory > /usr/bin/find: > `libraries/ghc-prim/dist-install/build/GHC/Debug_o_split': No such file > or directory > /usr/bin/find: > `libraries/ghc-prim/dist-install/build/GHC/Magic_o_split': No such file > or directory > /usr/bin/find: > `libraries/ghc-prim/dist-install/build/GHC/PrimopWrappers_o_split': No > such file or directory > /usr/bin/find: > `libraries/ghc-prim/dist-install/build/GHC/IntWord64_o_split': No such > file or directory > /usr/bin/find: > `libraries/ghc-prim/dist-install/build/GHC/Tuple_o_split': No such file > or directory > /usr/bin/find: > `libraries/ghc-prim/dist-install/build/GHC/Types_o_split': No such file > or directory > make[1]: *** > [libraries/ghc-prim/dist-install/build/libHSghc-prim-0.3.1.0.a] Error 1 > make: *** [all] Error 2 > > Anyone able to build a cross compiler with split-objs? It looks like we don't have split-objs support for ARM yet. It probably isn't too hard, but someone needs to look at the Perl script in driver/split/ghc-split.lprl. Cheers, Simon

1 0

[PATCH] #7595: Static flags code needs cleanup
by Jan Stolarek 29 Jan '13

29 Jan '13

I submitted a patch for ticket #7595 almost two weeks ago. It would be nice to have it reviewed and either accepted or rejected :) I know it's only a small refactoring of code, not a bug, and it may not be high on the priority list, but stil. http://hackage.haskell.org/trac/ghc/ticket/7595 Janek

2 2

HEADS UP (was Re: [commit: ghc] master: Tidy up cross-compiling (109a1e5))
by Simon Marlow 27 Jan '13

27 Jan '13

Cross-compilers please take note: On 17/01/13 12:57, Simon Marlow wrote: > Before > ------ > > To build a cross-compiler: > ./configure --target=<..> > > To compile a foreign GHC: > ./configure --host=<..> --target=<..> > > Now > --- > > To build a cross-compiler: > ./configure --target=<..> > And set "Stage1Only=YES" in mk/build.mk > > To compile a foreign GHC: > ./configure --target=<..> Cheers, Simon

5 9

RE: [GHC] #1614: Type checker does not use functional dependency to avoid ambiguity
by Simon Peyton-Jones 27 Jan '13

27 Jan '13

Please do endanger the code base! GHC needs people willing to have a go. * We try to review offered patches promptly (yell if this does not happen) * Worth discussing the general approach before investing a lot of time; the more substantial the change/fix the more discussion! Simon | -----Original Message----- | From: Andrew Adams-Moran [mailto:morabbin@gmail.com] | Sent: 27 January 2013 00:19 | To: Simon Peyton-Jones | Cc: ghc-devs(a)haskell.org | Subject: Re: [GHC] #1614: Type checker does not use functional dependency to | avoid ambiguity | | | Hi all! | | Thanks Simon; I figured this was good way for me to learn the conventions of the | team without endangering the code base. | | Thanks for the feedback, and consider it taken on board. | | Cheers, | | Andy | | On Jan 26, 2013, at 4:11 PM, Simon Peyton-Jones <simonpj(a)microsoft.com> | wrote: | | > Ah, so the mysterious and highly-active morabbin is none other than our old | friend and drinking companion Andy Adams-Moran! Welcome Andy! Thanks for | looking through these old tickets. | > | > | "Bump" is a cutesy internet name for this kind of bubbling something up to | the | > | top of the dev list. Please have another look at this ticket; here's what | > | I see (or not), maybe we can get rid of it." | > | > The trouble is that there aren't enough of these GHC devs to deal with the | hundreds of open tickets, bumped or not. When adding to a long-existing ticket, | there are really three modes of operation | > | > * This ticket is mission-critical to me; here's why; please please help. | > | > * Here is some new information. Eg. I tripped over this myself; here is the repro | case; or I think I may have an idea what's going on. | > | > * I'm going to have ago at fixing this. Here's how I propose to do it. Please yell | if I'm going awry here. | > | > But your "bump" seems to mean "I've looked at this and it still seems to be | open", and I don't know what to do about that. I'd love to have them *all* | attended to, but we need a lot more people to help if we are to achieve that. | > | > To simply indicate interest, the protocol is to add yourself to the cc list. Long cc | lists get more attention. Well some more attention! | http://hackage.haskell.org/trac/ghc/wiki/WorkingConventions/BugTracker | > | > Simon | > | > | -----Original Message----- | > | From: Andrew Adams-Moran [mailto:morabbin@gmail.com] | > | Sent: 26 January 2013 23:42 | > | To: Simon Peyton-Jones | > | Cc: ghc-devs(a)haskell.org | > | Subject: Re: [GHC] #1614: Type checker does not use functional dependency | to | > | avoid ambiguity | > | | > | | > | Hi Simon; | > | | > | "Bump" is a cutesy internet name for this kind of bubbling something up to | the | > | top of the dev list. | > | | > | "Please have another look at this ticket; here's what I see (or not), maybe | we | > | can get rid of it." | > | | > | In this case, it's also means that the commit is result of my ongoing attempt | to | > | revivify the bug sweep. So folks should feel free to ignore. | > | | > | (Also, do let me know if this is counter to GHC conventions, and I'll adapt | > | accordingly.) | > | | > | Cheers, | > | | > | Andy | > | | > | On Jan 26, 2013, at 3:15 PM, Simon Peyton-Jones <simonpj(a)microsoft.com> | > | wrote: | > | | > | > Morabbin, what's the semantics of "bump"? I don't know what you intend | by | > | it! | > | > | > | > Simon | > | > | > | > | -----Original Message----- | > | > | From: ghc-tickets-bounces(a)haskell.org [mailto:ghc-tickets- | > | bounces(a)haskell.org] | > | > | On Behalf Of GHC | > | > | Sent: 26 January 2013 22:12 | > | > | Cc: ghc-tickets(a)haskell.org | > | > | Subject: Re: [GHC] #1614: Type checker does not use functional | dependency | > | to | > | > | avoid ambiguity | > | > | | > | > | #1614: Type checker does not use functional dependency to avoid | ambiguity | > | > | --------------------------------------+------------------------------------- | > | > | Reporter: guest | Owner: | > | > | Type: bug | Status: new | > | > | Priority: normal | Milestone: _|_ | > | > | Component: Compiler (Type checker) | Version: 6.7 | > | > | Resolution: | Keywords: | > | > | Os: Unknown/Multiple | Architecture: Unknown/Multiple | > | > | Failure: None/Unknown | Difficulty: Unknown | > | > | Testcase: | Blockedby: | > | > | Blocking: | Related: | > | > | --------------------------------------+------------------------------------- | > | > | Changes (by morabbin): | > | > | | > | > | * failure: => None/Unknown | > | > | | > | > | | > | > | Comment: | > | > | | > | > | Bump; chak saya this was fixed in HEAD, and then SPJ closes as | wontfix? | > | > | Was the fix backed out? | > | > | | > | > | -- | > | > | Ticket URL: | <http://hackage.haskell.org/trac/ghc/ticket/1614#comment:11> | > | > | GHC <http://www.haskell.org/ghc/> | > | > | The Glasgow Haskell Compiler | > | > | | > | > | _______________________________________________ | > | > | ghc-tickets mailing list | > | > | ghc-tickets(a)haskell.org | > | > | http://www.haskell.org/mailman/listinfo/ghc-tickets | > | > | > | > _______________________________________________ | > | > ghc-devs mailing list | > | > ghc-devs(a)haskell.org | > | > http://www.haskell.org/mailman/listinfo/ghc-devs | >

1 0

RE: [GHC] #1614: Type checker does not use functional dependency to avoid ambiguity
by Simon Peyton-Jones 27 Jan '13

27 Jan '13

Ah, so the mysterious and highly-active morabbin is none other than our old friend and drinking companion Andy Adams-Moran! Welcome Andy! Thanks for looking through these old tickets. | "Bump" is a cutesy internet name for this kind of bubbling something up to the | top of the dev list. Please have another look at this ticket; here's what | I see (or not), maybe we can get rid of it." The trouble is that there aren't enough of these GHC devs to deal with the hundreds of open tickets, bumped or not. When adding to a long-existing ticket, there are really three modes of operation * This ticket is mission-critical to me; here's why; please please help. * Here is some new information. Eg. I tripped over this myself; here is the repro case; or I think I may have an idea what's going on. * I'm going to have ago at fixing this. Here's how I propose to do it. Please yell if I'm going awry here. But your "bump" seems to mean "I've looked at this and it still seems to be open", and I don't know what to do about that. I'd love to have them *all* attended to, but we need a lot more people to help if we are to achieve that. To simply indicate interest, the protocol is to add yourself to the cc list. Long cc lists get more attention. Well some more attention! http://hackage.haskell.org/trac/ghc/wiki/WorkingConventions/BugTracker Simon | -----Original Message----- | From: Andrew Adams-Moran [mailto:morabbin@gmail.com] | Sent: 26 January 2013 23:42 | To: Simon Peyton-Jones | Cc: ghc-devs(a)haskell.org | Subject: Re: [GHC] #1614: Type checker does not use functional dependency to | avoid ambiguity | | | Hi Simon; | | "Bump" is a cutesy internet name for this kind of bubbling something up to the | top of the dev list. | | "Please have another look at this ticket; here's what I see (or not), maybe we | can get rid of it." | | In this case, it's also means that the commit is result of my ongoing attempt to | revivify the bug sweep. So folks should feel free to ignore. | | (Also, do let me know if this is counter to GHC conventions, and I'll adapt | accordingly.) | | Cheers, | | Andy | | On Jan 26, 2013, at 3:15 PM, Simon Peyton-Jones <simonpj(a)microsoft.com> | wrote: | | > Morabbin, what's the semantics of "bump"? I don't know what you intend by | it! | > | > Simon | > | > | -----Original Message----- | > | From: ghc-tickets-bounces(a)haskell.org [mailto:ghc-tickets- | bounces(a)haskell.org] | > | On Behalf Of GHC | > | Sent: 26 January 2013 22:12 | > | Cc: ghc-tickets(a)haskell.org | > | Subject: Re: [GHC] #1614: Type checker does not use functional dependency | to | > | avoid ambiguity | > | | > | #1614: Type checker does not use functional dependency to avoid ambiguity | > | --------------------------------------+------------------------------------- | > | Reporter: guest | Owner: | > | Type: bug | Status: new | > | Priority: normal | Milestone: _|_ | > | Component: Compiler (Type checker) | Version: 6.7 | > | Resolution: | Keywords: | > | Os: Unknown/Multiple | Architecture: Unknown/Multiple | > | Failure: None/Unknown | Difficulty: Unknown | > | Testcase: | Blockedby: | > | Blocking: | Related: | > | --------------------------------------+------------------------------------- | > | Changes (by morabbin): | > | | > | * failure: => None/Unknown | > | | > | | > | Comment: | > | | > | Bump; chak saya this was fixed in HEAD, and then SPJ closes as wontfix? | > | Was the fix backed out? | > | | > | -- | > | Ticket URL: <http://hackage.haskell.org/trac/ghc/ticket/1614#comment:11> | > | GHC <http://www.haskell.org/ghc/> | > | The Glasgow Haskell Compiler | > | | > | _______________________________________________ | > | ghc-tickets mailing list | > | ghc-tickets(a)haskell.org | > | http://www.haskell.org/mailman/listinfo/ghc-tickets | > | > _______________________________________________ | > ghc-devs mailing list | > ghc-devs(a)haskell.org | > http://www.haskell.org/mailman/listinfo/ghc-devs

1 0

RE: [GHC] #1614: Type checker does not use functional dependency to avoid ambiguity
by Simon Peyton-Jones 27 Jan '13

27 Jan '13

Morabbin, what's the semantics of "bump"? I don't know what you intend by it! Simon | -----Original Message----- | From: ghc-tickets-bounces(a)haskell.org [mailto:ghc-tickets-bounces@haskell.org] | On Behalf Of GHC | Sent: 26 January 2013 22:12 | Cc: ghc-tickets(a)haskell.org | Subject: Re: [GHC] #1614: Type checker does not use functional dependency to | avoid ambiguity | | #1614: Type checker does not use functional dependency to avoid ambiguity | --------------------------------------+------------------------------------- | Reporter: guest | Owner: | Type: bug | Status: new | Priority: normal | Milestone: _|_ | Component: Compiler (Type checker) | Version: 6.7 | Resolution: | Keywords: | Os: Unknown/Multiple | Architecture: Unknown/Multiple | Failure: None/Unknown | Difficulty: Unknown | Testcase: | Blockedby: | Blocking: | Related: | --------------------------------------+------------------------------------- | Changes (by morabbin): | | * failure: => None/Unknown | | | Comment: | | Bump; chak saya this was fixed in HEAD, and then SPJ closes as wontfix? | Was the fix backed out? | | -- | Ticket URL: <http://hackage.haskell.org/trac/ghc/ticket/1614#comment:11> | GHC <http://www.haskell.org/ghc/> | The Glasgow Haskell Compiler | | _______________________________________________ | ghc-tickets mailing list | ghc-tickets(a)haskell.org | http://www.haskell.org/mailman/listinfo/ghc-tickets

2 1

Re: pgj (x86 FreeBSD HEAD), build 925, Failure
by Ian Lynagh 26 Jan '13

26 Jan '13

On Fri, Jan 25, 2013 at 05:47:03PM -0800, Builder wrote: > pgj (x86 FreeBSD HEAD), build 925 > > Build failed > Details: http://darcs.haskell.org/ghcBuilder/builders/pgj/925.html > > checking for __gmpz_fdiv_qr in -lgmp... no > checking for __gmpz_fdiv_qr in -lgmp3... no > configure: error: Failed to compute size of sizeof (MP_INT) > gmake[1]: *** [libraries/integer-gmp/dist-install/package-data.mk] Error 1 > gmake: *** [all] Error 2 > checking for sizeof (MP_INT) size... My Win32 HEAD build failed the same way: checking for __gmpz_fdiv_qr in -lgmp3... no checking for sizeof (MP_INT) size... configure: error: Failed to compute size of sizeof (MP_INT) libraries/integer-gmp/ghc.mk:4: recipe for target `libraries/integer-gmp/dist-install/package-data.mk' failed make[1]: *** [libraries/integer-gmp/dist-install/package-data.mk] Error 1 Does anyone know what's up? Thanks Ian

4 3

Problem in C Code Generator, with patch
by Christopher Vollick 26 Jan '13

26 Jan '13

Hey guys! So, I was working on some cross-compiling, and found a bug (http://hackage.haskell.org/trac/ghc/ticket/7620) Eventually I found that the issue was with C CodeGen in general, and had nothing to do with ARM. I've attached the patch there, but it may be only part of a bigger problem. The rough problem came from two things: 1) -(-128 :: Int8) => -128 You can't negate the smallest int in an integer space because of how 2s compliment works. There aren't enough bits to store +128. 2) We have a number of operations that transform: | i < 0 = a + i => a - (negative i) And | i < 0 = a - i => a + (negative i) And the assumption is that any integer can be negated, but that's not true in exactly one case. So, for example, it could turn thing+-128 into thing--128 Which is not valid C. That (but for Int32) was what I was seeing, and causing me trouble building integer simple. So, that was the bug I had encountered, and I don't know how the GHC code works, I just trawled through until I found the line that was causing me trouble, but I just figured I'd remind people that not every integer can be negated, in case the same mistake is being done in other places.

1 0