- ghc-devs - Haskell.org

RE: Where do I put the *definition* of a DFunId?
by Erdi, Gergo 16 Feb '22

16 Feb '22

PUBLIC > I'm not surprised that eventually it crashes and burns, because, > again, I have only declared my DFunId ('$fShowOrderPolicy' in this > case), but never defined it. Its definition would be a CoreExpr, > right? So where would I put the pair of '(dfun, > myCoreExprOfTheRightType)' for GHC to pick it up? Or is it the case > that GHC would only need an 'Id's definition if it is trying to > inline/specialize it, i.e. should I just attach the definition to the > DFunId as an unfolding? Or is 'registerModule' already incomplete and > it should put the 'CoreProgram' of the module to somewhere deep in the > GHC state? I tried adding a reasonable-looking unfolding to the DFun, but I am still getting the same error when compiling code that uses the instance: $fShowOrderPolicy [InlPrag=CONLIKE] :: Show OrderPolicy [LclIdX[DFunId], Unf=DFun: \ -> C:Show \ _ [Occ=Dead] -> unpackCStringUtf8# "foo"# \ _ [Occ=Dead] _ [Occ=Dead] _ [Occ=Dead] -> unpackCStringUtf8# "bar"# \ _ [Occ=Dead] _ [Occ=Dead] -> unpackCStringUtf8# "baz"#] panic! (the 'impossible' happened) GHC version 9.3.20211130: lookupIdSubst $fShowOrderPolicy InScope {foo mapM_} Call stack: CallStack (from HasCallStack): callStackDoc, called at compiler/GHC/Utils/Panic.hs:181:37 in ghc-lib-0.20211130-7QA7vLTw0OYJmMsraoHe3v:GHC.Utils.Panic pprPanic, called at compiler/GHC/Core/Subst.hs:260:17 in ghc-lib-0.20211130-7QA7vLTw0OYJmMsraoHe3v:GHC.Core.Subst I have added a minimal working reproducer to https://gitlab.haskell.org/ghc/ghc/-/issues/21080 So the question remains, where do I need to put the DFun's definition (a CoreExpr of the right type) for it to be usable as an instance? Thanks, Gergo This email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please delete all copies and notify the sender immediately. You may wish to refer to the incorporation details of Standard Chartered PLC, Standard Chartered Bank and their subsidiaries at https: //www.sc.com/en/our-locations Where you have a Financial Markets relationship with Standard Chartered PLC, Standard Chartered Bank and their subsidiaries (the "Group"), information on the regulatory standards we adhere to and how it may affect you can be found in our Regulatory Compliance Statement at https: //www.sc.com/rcs/ and Regulatory Compliance Disclosures at http: //www.sc.com/rcs/fm Insofar as this communication is not sent by the Global Research team and contains any market commentary, the market commentary has been prepared by the sales and/or trading desk of Standard Chartered Bank or its affiliate. It is not and does not constitute research material, independent research, recommendation or financial advice. Any market commentary is for information purpose only and shall not be relied on for any other purpose and is subject to the relevant disclaimers available at https: //www.sc.com/en/regulatory-disclosures/#market-disclaimer. Insofar as this communication is sent by the Global Research team and contains any research materials prepared by members of the team, the research material is for information purpose only and shall not be relied on for any other purpose, and is subject to the relevant disclaimers available at https: //research.sc.com/research/api/application/static/terms-and-conditions. Insofar as this e-mail contains the term sheet for a proposed transaction, by responding affirmatively to this e-mail, you agree that you have understood the terms and conditions in the attached term sheet and evaluated the merits and risks of the transaction. We may at times also request you to sign the term sheet to acknowledge the same. Please visit https: //www.sc.com/en/regulatory-disclosures/dodd-frank/ for important information with respect to derivative products.

1 0

install stage0 libraries?
by Norman Ramsey 11 Feb '22

11 Feb '22

If I understand correctly, the way Hadrian works is that all of the .conf files, binaries, and so on in _build/stage0 are built with the bootstrap compiler. I need to write client code that uses the ghc library built from GHC HEAD (so ghc-9.3), but I'd prefer to use the bootstrap compiler. (The HLS works with the bootstrap compiler.) Is there a way to get Hadrian to install the stage0 libraries in a way that cabal-install can find it using standard options? I tried to do it myself using `ghc-pkg register`, and all I accomplished was to make an unrecoverable mess of my system. (The problem I'm trying to solve is to get my client code to compile against the latest library, while also enabling the HLS to find all the things.) Norman

1 0

Where do I put the *definition* of a DFunId?
by Erdi, Gergo 11 Feb '22

11 Feb '22

PUBLIC PUBLIC Hi, I'm trying to make a module out of thin air and register it to GHC so that other modules can import it. So far, I have had success with making a ModIface and a ModDetails, and then registering them using the following function: registerModule :: (GhcMonad m) => ModIface -> ModDetails -> m () registerModule iface details = modifySession $ extendHpt . addModule where mod_info = HomeModInfo iface details Nothing mod = mi_module iface modOrig = ModOrigin (Just True) [] [] True addModule = modifyUnitState $ \us -> us { moduleNameProvidersMap = M.insert (moduleName mod) (M.singleton mod modOrig) $ moduleNameProvidersMap us } extendHpt env = env { hsc_unit_env = let ue = hsc_unit_env env in ue { ue_hpt = hpt } } where hpt = addToHpt (hsc_HPT env) (moduleName mod) mod_info This worked when I was only _declaring_ functions and TyCons in these modules. However, now I would also like to add instances. And I'm hitting a problem here, because I don't know where to put the actual definitions of the instance. I'm completely lost here. Here's what I'm doing in detail. First, I make a fresh DFunId from a fresh Unique: let tag = occNameString . getDFunTyKey $ ty occ = mkDFunOcc (occNameString (getOccName showClass) <> tag) False emptyOccSet name = mkExternalName uniq mod occ loc dfun = mkDictFunId name [] [] showClass [ty] Then, I make a ClsInst that describes my instance: return ClsInst { is_cls_nm = getName showClass , is_tcs = [KnownTc $ getName tycon] , is_dfun_name = getName dfun , is_tvs = [] , is_cls = showClass , is_tys = [ty] , is_dfun = dfun , is_flag = OverlapFlag (NoOverlap NoSourceText) False , is_orphan = NotOrphan (getOccName $ getName tycon) } And then I add 'AnId dfun' to my ModDetails's type env in 'md_types',, add the instance to the 'md_insts', and fill the 'mi_decls' and 'mi_insts' of the ModIface accordingly. This gives me a ModIface/ModDetails pair just like before - but I never said what the definition of 'dfun' is! When I try compiling a real source module that imports this synthetic module and tries to use the instance, it gets as far as the "Desugar (after optimization)" step, and then fails with: ghc-mu-core-to-exp: panic! (the 'impossible' happened) GHC version 9.3.20211130: lookupIdSubst $fShowOrderPolicy InScope {foo mapM_} Call stack: CallStack (from HasCallStack): callStackDoc, called at compiler/GHC/Utils/Panic.hs:181:37 in ghc-lib-0.20211130-7QA7vLTw0OYJmMsraoHe3v:GHC.Utils.Panic pprPanic, called at compiler/GHC/Core/Subst.hs:260:17 in ghc-lib-0.20211130-7QA7vLTw0OYJmMsraoHe3v:GHC.Core.Subst I'm not surprised that eventually it crashes and burns, because, again, I have only declared my DFunId ('$fShowOrderPolicy' in this case), but never defined it. Its definition would be a CoreExpr, right? So where would I put the pair of '(dfun, myCoreExprOfTheRightType)' for GHC to pick it up? Or is it the case that GHC would only need an 'Id's definition if it is trying to inline/specialize it, i.e. should I just attach the definition to the DFunId as an unfolding? Or is 'registerModule' already incomplete and it should put the 'CoreProgram' of the module to somewhere deep in the GHC state? Thanks, Gergo This email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please delete all copies and notify the sender immediately. You may wish to refer to the incorporation details of Standard Chartered PLC, Standard Chartered Bank and their subsidiaries at https: //www.sc.com/en/our-locations Where you have a Financial Markets relationship with Standard Chartered PLC, Standard Chartered Bank and their subsidiaries (the "Group"), information on the regulatory standards we adhere to and how it may affect you can be found in our Regulatory Compliance Statement at https: //www.sc.com/rcs/ and Regulatory Compliance Disclosures at http: //www.sc.com/rcs/fm Insofar as this communication is not sent by the Global Research team and contains any market commentary, the market commentary has been prepared by the sales and/or trading desk of Standard Chartered Bank or its affiliate. It is not and does not constitute research material, independent research, recommendation or financial advice. Any market commentary is for information purpose only and shall not be relied on for any other purpose and is subject to the relevant disclaimers available at https: //www.sc.com/en/regulatory-disclosures/#market-disclaimer. Insofar as this communication is sent by the Global Research team and contains any research materials prepared by members of the team, the research material is for information purpose only and shall not be relied on for any other purpose, and is subject to the relevant disclaimers available at https: //research.sc.com/research/api/application/static/terms-and-conditions. Insofar as this e-mail contains the term sheet for a proposed transaction, by responding affirmatively to this e-mail, you agree that you have understood the terms and conditions in the attached term sheet and evaluated the merits and risks of the transaction. We may at times also request you to sign the term sheet to acknowledge the same. Please visit https: //www.sc.com/en/regulatory-disclosures/dodd-frank/ for important information with respect to derivative products.

3 3

the linters are killing me slowly
by Richard Eisenberg 10 Feb '22

10 Feb '22

Hi devs, Can we please, please not have the linters stop more useful output during CI? Over the past few months, I've lost several days of productivity due to the current design. Why several days? Because I typically end up with only 1.5-2 hours for GHC work in a day, and when I have to spend half of that recreating test results (which, sometimes, don't work, especially if I use Hadrian, as recommended), I often decide to prioritize other tasks that I have a more reasonable chance of actually finishing. It was floated some time ago that "Draft" MRs could skip linters. But I actually have a non-Draft MR now, and it failed the new Notes linter. (Why, actually, is that even a separate pass? I thought there was a test case for that, which I'm thrilled with.) It just feels to me that the current workflow is optimized for those of us who work on GHC close to 100% of the time. This is not the way to get new contributors. Frustrated, Richard

6 7

how to complete a review on gitlab?
by Norman Ramsey 09 Feb '22

09 Feb '22

I've been assigned a few merge requests to review on gitlab. One I've completed and approved. One I've completed and have decided that somebody else needs to approve it; I'm not qualified. Two I've not yet started. Is there any way to tell gitlab, "I'm done with these two"? Norman

2 1

Runnig a compiler plugin over ALL code
by Tillmann Vogt 09 Feb '22

09 Feb '22

Hi, I am running a compiler plugin over hundreds of libraries to extract statistical data. I use the plugin like it is done here: https://github.com/coot/ghc-tags-plugin So I just have to add a cabal.project.local to a library with: ignore-project: False package test ghc-options: -package-db=/home/till/.cabal/store/ghc-8.10.7/package.db -plugin-package=ghc-core-graph -fplugin=GhcPlugins.Optimind But unfortunately the plugin only runs over code that is used in the main function or that is used in other functions. Example: main = putStrLn (show (f 0)) f x = sin x g = h + i Then the compiler plugin only runs over f, h, i but not not g (unused top level functions). Can the plugin be forced to run over all code? -Tillmann

2 1

ettiquette for changing an MR under review?
by Norman Ramsey 08 Feb '22

08 Feb '22

I have an MR currently under review. Review has already identified a change I need to make, and I have made it in my local repository. Do I push the change now, or do I wait for a more complete review? And if I push it now, do I force-push or do I push the changes as a separate commit? Norman

2 1

Notes Linter
by Matthew Pickering 08 Feb '22

08 Feb '22

Hello, Just merged is a new linter which checks the consistency of notes. In particular it checks that all note references reference an existing Note. The linter is integrated into the testsuite so you can run the linter (without building GHC) by saying ./hadrian/build test --only=notes and can accept the new output of the linter by saying ./hadrian/build test --only=notes --test-accept But you should probably not need to do this and instead fix your note references! Any issues please open a ticket. Cheers, Matt

1 0

9.2.2 release schedule?
by Shayne Fletcher 03 Feb '22

03 Feb '22

Anyone know of any scheduling plans for ghc-9.2.2? Happy holidays y'all :) -- Shayne Fletcher

4 5

way to lint my GHC sources?
by Norman Ramsey 02 Feb '22

02 Feb '22

Is there a way for me to run the GHC linter on my GHC source tree, without having to push an MR out to CI? Norman

2 1