- ghc-devs - Haskell.org

Bug in "changes" tab in Gitlab
by Ömer Sinan Ağacan 16 Jan '19

16 Jan '19

Hi, I think there's a currently a bug in "changes" tab in gitlab. If you look at [1] it shows as if I added a new line in `Main.hs`, but actually I just changed one word: diff --git a/utils/genapply/Main.hs b/utils/genapply/Main.hs index 71b84fde79..7038dc5c09 100644 --- a/utils/genapply/Main.hs +++ b/utils/genapply/Main.hs @@ -903,7 +903,7 @@ genStackApply regstatus args = -- -- These code fragments are used to save registers on the stack at a heap -- check failure in the entry code for a function. We also have to save R1 --- and the return address (stg_gc_fun_info) on the stack. See stg_gc_fun_gen +-- and the return address (stg_gc_fun_info) on the stack. See __stg_gc_fun -- in HeapStackCheck.cmm for more details. I'm guessing that Gitlab is confused by the `---` prefix in the diff. I was going to report it but I realized that we're not using the latest version (the "help" page says "update asap"), so perhaps we should try updating first? [1]: https://gitlab.haskell.org/ghc/ghc/merge_requests/125/diffs?view=parallel Ömer

2 1

RE: GHC | Some refactoring in tcInferApps (!116)
by Simon Peyton Jones 15 Jan '19

15 Jan '19

Thanks. But none of the pictures arrived, so I can’t interpret what you say. I think I did see Richards face here and there (and mine), if that’s want avatars means. Hovering showed a snippet of a comment; but clicking did nothing. I’m also terribly reluctant to scroll through thousands of lines of diff looking for avarars. Simon From: ghc-devs <ghc-devs-bounces(a)haskell.org> On Behalf Of Sylvain Henry Sent: 14 January 2019 16:21 To: ghc-devs(a)haskell.org Subject: Re: GHC | Some refactoring in tcInferApps (!116) Hi Simon, In the diff view, you can click on the avatars on the left to expand discussions: [cid:part1.E17582DB.274298F8@haskus.fr] Or you can click on the "toggle comments for this file" button: [cid:part2.D9953BB2.A74D4E27@haskus.fr] If you are willing to use GreaseMonkey (Firefox extension) or TamperMonkey (Chrome/Chromium extension), you can use the attached script to add new buttons to GitLab UI: [cid:part3.9CF91D30.FC1AF3DA@haskus.fr] [cid:part4.5144A0AF.98359F8A@haskus.fr] Tested on Firefox and Chromium on Linux. Sylvain On 14/01/2019 11:58, Simon Peyton Jones via ghc-devs wrote: | (without the 'diff' at the end) you can see the collapsed discussion items? Yes, in the discussion tab I can. But of course that is out of context; you just get a little (non-expandable) snippet. Simon | -----Original Message----- | From: Mikolaj Konarski <mikolaj(a)well-typed.com><mailto:mikolaj@well-typed.com> | Sent: 14 January 2019 10:30 | To: Simon Peyton Jones <simonpj(a)microsoft.com><mailto:simonpj@microsoft.com> | Cc: ghc-devs <ghc-devs(a)haskell.org><mailto:ghc-devs@haskell.org> | Subject: Re: GHC | Some refactoring in tcInferApps (!116) | | > Looking here | > https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitl | > ab.haskell.org%2Fghc%2Fghc%2Fmerge_requests%2F116%2F%2Fdiffs&data= | > 02%7C01%7Csimonpj%40microsoft.com%7Cb565eeb2f6fe445fc64f08d67a0b40fe%7 | > C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636830586093208883&sda | > ta=qAcz0zoXCCQHFeJ39ABKAVwtN5a2pIwyRSbfJcLSurk%3D&reserved=0 | > I see literally NO discussions with a "toggle discussion" button. Indeed | if I search for "toggle" I get no hits. | | Oh, I see, you are right with respect to the link you cited now. | None of the buttons help, just as you say. I have to navigate back from the | "Changes" to the "Discussion" tab, which gets me to the link you gave | initially | (https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.h | askell.org%2Fghc%2Fghc%2Fmerge_requests%2F116&data=02%7C01%7Csimonpj%40 | microsoft.com%7Cb565eeb2f6fe445fc64f08d67a0b40fe%7C72f988bf86f141af91ab2d7c | d011db47%7C1%7C0%7C636830586093208883&sdata=1pFmcwPyptWE8XOs%2FdnykEqsm | 4ag7%2BqBi3c4qpAE7sE%3D&reserved=0) | where the discussions are available, but I can't see them in the context of | the whole diff and none of the buttons there let me extend the view of the | diff. That's quite suboptimal. | | Could you confirm that at | | https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.ha | skell.org%2Fghc%2Fghc%2Fmerge_requests%2F116&data=02%7C01%7Csimonpj%40m | icrosoft.com%7Cb565eeb2f6fe445fc64f08d67a0b40fe%7C72f988bf86f141af91ab2d7cd | 011db47%7C1%7C0%7C636830586093208883&sdata=1pFmcwPyptWE8XOs%2FdnykEqsm4 | ag7%2BqBi3c4qpAE7sE%3D&reserved=0 | | (without the 'diff' at the end) you can see the collapsed discussion items? _______________________________________________ ghc-devs mailing list ghc-devs(a)haskell.org<mailto:ghc-devs@haskell.org> http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs<https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmail.haske…>

3 2

Max identifier length
by Christopher Done 15 Jan '19

15 Jan '19

Hey, Quick question: Does GHC have an upper limit on the length of binding names? Cheers!

3 2

RE: GHC | Some refactoring in tcInferApps (!116)
by Simon Peyton Jones 14 Jan '19

14 Jan '19

Devs I’m at a loss for how to review GitLab changes. Richard sent me the message below. So I follow the link to “View on GitLab”, or I manually edit the URL to plain https://gitlab.haskell.org/ghc/ghc/merge_requests/116 Either way, I can’t see any comments whatsoever! It says 5/5 discussions resolved, but I can’t actually see them. There is not “toggle discussion” button anywhere. What should I do? This is quite a big problem. I suppose we could issue guidance NEVER to resolve a discussion, but that seems like the wrong conclusion. Simon From: Richard Eisenberg <gitlab(a)gitlab.haskell.org> Sent: 14 January 2019 03:03 To: Simon Peyton Jones <simonpj(a)microsoft.com> Subject: Re: GHC | Some refactoring in tcInferApps (!116) Richard Eisenberg<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.ha…> commented on a discussion on compiler/typecheck/TcHsType.hs<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.ha…>: 1022 + (vcat [ ppr ki_binder 1023 + , ppr ki_arg 1024 + , ppr (tyBinderType ki_binder) 1025 + , ppr subst 1026 + , ppr (isInvisibleBinder ki_binder) ]) 1027 + ; ty_app_err ki_arg $ nakedSubstTy subst $ 1028 + mkPiTys all_ki_binders inner_ki } 1029 + 1030 + -- no binder; try applying the substitution, or fail if that's not possible 1031 + | otherwise 1032 + = try_again_after_substing_or n subst fun inner_ki all_args $ \ substed_inner_ki -> 1033 + ty_app_err ki_arg substed_inner_ki 1034 + 1035 + go n subst fun all_ki_binders inner_ki all_args@(HsValArg arg : args) 1036 + | ki_binder : ki_binders <- all_ki_binders 1037 + = if isInvisibleBinder ki_binder See if you like how I've done this now. — View it on GitLab<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.ha…>. You're receiving this email because of your account on gitlab.haskell.org. If you'd like to receive fewer emails, you can unsubscribe<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.ha…> from this thread or adjust your notification settings.

4 8

Reviews
by Simon Peyton Jones 12 Jan '19

12 Jan '19

When reviewing a MR, I sometimes want to look at (and even add comments to) code that isn't displayed in the MR window. With Phab there was a "show 20 more lines" link, and even "show the whole file". How do I do that in GitLab? When submitting a review, I often want to add an overall comment, not related to a particular line of code? How do I do that? Thanks Simoin

5 14

More GitLab questions
by Simon Peyton Jones 11 Jan '19

11 Jan '19

* When looking at a comment on a MR, I see some snippet of code. How can I see what module that snippet is in? Apart from scrolling up to find the file header - being careful not to miss it and scroll into the previous file. * When looking a comment, there's a little button to skip to the next unresolved comment. Good. But if I respond to the comment (without resolving it), that little button disappears. How can I find the next unresolved comment? Simon

2 3

Changes to UserSettings.hs
by Matthew Pickering 10 Jan '19

10 Jan '19

Hi all, Last night my patch got merged which changed some aspects of the hadrian settings file. If you have a custom settings file (ie hadrian/UserSettings.hs), you need to remove reference to the `stage1Only` variable and add a new variable called `finalStage` which should default to `Stage2`. https://gitlab.haskell.org/ghc/ghc/commit/6486c6e49c53e75f37ed732b38c5be7ae… Cheers, Matt

1 0

Gitlab notes
by Simon Peyton Jones 09 Jan '19

09 Jan '19

Friends I've added a Wiki page to summarise things I've learned about Gitlab. Please do correct any errors I've made! https://ghc.haskell.org/trac/ghc/wiki/WorkingConventions/GitLabSPJ Thanks Simon

5 6

Hadrian
by Simon Peyton Jones 09 Jan '19

09 Jan '19

Alp You've written a helpful wiki page describing how to use Hadrian https://gitlab.haskell.org/ghc/ghc/blob/master/hadrian/doc/make.md Could you document where build-products live? I often look at .hi files. Could you add * How to do the equivalent of "sh validate" * When validating, how to do things like this: GhcStage1HcOpts += -DDEBUG -O GhcStage2HcOpts += -Wwarn -ticky GhcLibHcOpts += -ticky -Wwarn BUILD_PROF_LIBS = NO SplitObjs = YES HADDOCK_DOCS = NO BUILD_SPHINX_HTML = NO BUILD_SPHINX_PDF = NO * After modifying the source code, how to make stage1 compiler (only). In 'make' it is $ cd compiler; make 1 * After modifying the source code, build the stage2 compiler (only). In 'make' it is $ cd compiler; make 2 Perhaps you say build -freeze1? * In the testsuite, how to use the stage1 compiler $ make stage=1 TEST=T2543 * In nofib, how to build one benchmark, with extra flags, perhaps even with the stage1 compiler $ make stage=1 EXTRA_HC_OPTS="-ticky -ddump-simpl -ddump-stg" Thanks! Simon

2 4

Blocking a task indefinitely in the RTS
by Phyx 09 Jan '19

09 Jan '19

Hi All, I'm looking for a way to block a task indefinitely until it is woken up by an external event in both the threaded and non-threaded RTS and returns a value that was stored/passed. MVar works great for the threaded RTS, but for the non-threaded there's a bunch of deadlock detection in the scheduler that would forcibly free the lock and resume the task with an opaque exception. This means that MVar and anything derived from it is not usable. STMs are more expensive but also have the same deadlock code. So again no go. The reason it looks like a deadlock to the RTS is that the "Wake-up" call in the non-threaded rts will come from C code running inside the RTS. The RTS essentially just sees all tasks blocked on it's main capability and (usually rightly so) assumes a deadlock occurred. You have other states like BlockedOnForeign etc but those are not usable as a primitive. Previous iterations of I/O managers have each invented primitives for this such as asyncRead#, but they are not general and can't be re-used, and requires a different solution for threaded and non-threaded. I have started making a new primitive IOPort for this, based on the MVar code, but this is not trivial... (currently I'm getting a segfault *somewhere* in the primitive's cmm code). The reason is that the semantics are decidedly different from what MVars guarantee. I should also mention that this is meant to be internal to base (i.e no exported). So before I continue down this path and some painful debugging..., does anyone know of a way to block a task, unblock it later and pass a value back? It does not need to support anything complicated such as multiple take/put requests etc. Cheers, Tamar

4 12